This repository was archived by the owner on Mar 20, 2024. It is now read-only.
fix: Illegal invocation calling window.getComputedStyle #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsaguet
force-pushed
the
fix/illegal-invocation-error
branch
from
d922786 to
77365c9
Compare
8 tasks
|
Hello @CaerusKaru @jsaguet! Do you have any updates about the PR? We're trying to upgrade Angular 12 to the latest minor version. Unfortunately, we're not able to downgrade Angular to 12.1.4 because we use @angular-builders/custom-webpack which uses the latest minor version of Angular by default and the issue is blocking the Angular upgrade. Thank you! |
|
Hi @jsaguet Thanks a lot for the fix! Are there any updates on this? Looks like the missing CLA might prevent this PR from being merged. |
|
@jsaguet Could you sign the CLA? |
|
I already did |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #135
I've tested this change in an application of my own that was affected by this error and it seems to be working properly this way.
Illegal invocation error is thrown as described in #135
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information: