This repository was archived by the owner on Dec 6, 2017. It is now read-only.
[WIP]Prevent overriding providers by default (fix #48) #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add an `allowOverride` parameter if override is really intended
|
I agree with that. I don't think it adds a whole lot of value to the error message. |
| @@ -66,8 +67,9 @@ class Module { | |||
| * implied that [id] should be instantiated. | |||
| */ | |||
| void type(Type id, {Type implementedBy, CreationStrategy creation, | |||
| Visibility visibility}) { | |||
| Visibility visibility, bool allowOverride: false}) { | |||
There was a problem hiding this comment.
allowOverride should probably just be override. allowOverride makes me think that while defining this type binding I would like to [dis]allow others to override this binding, rather than I might be overriding an existing binding with this one.
vicb
added a commit
to vicb/di.dart
that referenced
this pull request
Feb 3, 2014
Extracted from dart-archive#51 as the PR is being discussed.
Closed
|
Do we still want this? |
|
Closing for now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.