From 661dad2214854fbbcf579ff8c5674e6bc004092b Mon Sep 17 00:00:00 2001 From: Adam Plumer Date: Wed, 19 Jul 2017 00:32:27 -0400 Subject: [PATCH] feat(divider): move divider out of mat-list - Creates an independent mat-divider component - Adds inset capability with special accomodations for mat-list-item - Adds vertical option - Removed mat-divider from MatListModule with temporary import to prevent breaking changes - Added styling for dividers in cards - Add demos for use in list, card, and menu --- .github/CODEOWNERS | 1 + src/demo-app/card/card-demo.html | 17 +++++ src/demo-app/demo-material-module.ts | 2 + src/demo-app/list/list-demo.html | 3 +- src/demo-app/menu/menu-demo.html | 18 +++++ src/demo-app/system-config.ts | 1 + src/e2e-app/e2e-app-module.ts | 2 + src/e2e-app/system-config.ts | 1 + src/lib/card/card.scss | 16 +++++ src/lib/core/theming/_all-theme.scss | 2 + src/lib/divider/README.md | 1 + src/lib/divider/_divider-theme.scss | 15 +++++ src/lib/divider/divider-module.ts | 25 +++++++ src/lib/divider/divider.md | 55 ++++++++++++++++ src/lib/divider/divider.scss | 23 +++++++ src/lib/divider/divider.spec.ts | 66 +++++++++++++++++++ src/lib/divider/divider.ts | 38 +++++++++++ src/lib/divider/index.ts | 9 +++ src/lib/divider/public-api.ts | 10 +++ src/lib/divider/tsconfig-build.json | 14 ++++ src/lib/list/_list-theme.scss | 4 -- src/lib/list/list-module.ts | 10 +-- src/lib/list/list.scss | 31 +++++++-- src/lib/list/list.ts | 22 ------- src/lib/public-api.ts | 1 + .../divider-overview-example.css | 1 + .../divider-overview-example.html | 7 ++ .../divider-overview-example.ts | 10 +++ src/material-examples/example-module.ts | 8 +++ src/material-examples/material-module.ts | 3 +- .../kitchen-sink/kitchen-sink.ts | 2 + test/karma-test-shim.js | 1 + 32 files changed, 378 insertions(+), 41 deletions(-) create mode 100644 src/lib/divider/README.md create mode 100644 src/lib/divider/_divider-theme.scss create mode 100644 src/lib/divider/divider-module.ts create mode 100644 src/lib/divider/divider.md create mode 100644 src/lib/divider/divider.scss create mode 100644 src/lib/divider/divider.spec.ts create mode 100644 src/lib/divider/divider.ts create mode 100644 src/lib/divider/index.ts create mode 100644 src/lib/divider/public-api.ts create mode 100644 src/lib/divider/tsconfig-build.json create mode 100644 src/material-examples/divider-overview/divider-overview-example.css create mode 100644 src/material-examples/divider-overview/divider-overview-example.html create mode 100644 src/material-examples/divider-overview/divider-overview-example.ts diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index d104fce58894..b7d217ec9977 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -8,6 +8,7 @@ /src/lib/chips/** @tinayuangao /src/lib/datepicker/** @mmalerba /src/lib/dialog/** @jelbourn @crisbeto +/src/lib/divider/** @jelbourn @crisbeto /src/lib/expansion/** @josephperrott @jelbourn /src/lib/form-field/** @mmalerba /src/lib/grid-list/** @kara @jelbourn diff --git a/src/demo-app/card/card-demo.html b/src/demo-app/card/card-demo.html index 221c295e0d77..bde2eee3829b 100644 --- a/src/demo-app/card/card-demo.html +++ b/src/demo-app/card/card-demo.html @@ -27,6 +27,23 @@ + + Subtitle + Card with title, footer, and inset-divider + +

This is supporting text.

+

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

+
+ + + + + + + + +
+ Content Title diff --git a/src/demo-app/demo-material-module.ts b/src/demo-app/demo-material-module.ts index e649fe88457e..33ff49f3c389 100644 --- a/src/demo-app/demo-material-module.ts +++ b/src/demo-app/demo-material-module.ts @@ -16,6 +16,7 @@ import { MatChipsModule, MatDatepickerModule, MatDialogModule, + MatDividerModule, MatExpansionModule, MatFormFieldModule, MatGridListModule, @@ -63,6 +64,7 @@ import {PortalModule} from '@angular/cdk/portal'; MatTableModule, MatDatepickerModule, MatDialogModule, + MatDividerModule, MatExpansionModule, MatFormFieldModule, MatGridListModule, diff --git a/src/demo-app/list/list-demo.html b/src/demo-app/list/list-demo.html index d3f3a87f100b..96aea4632f04 100644 --- a/src/demo-app/list/list-demo.html +++ b/src/demo-app/list/list-demo.html @@ -24,13 +24,14 @@

{{contact.name}}

Today

- + Image of {{message.from}}

{{message.from}}

{{message.subject}} -- {{message.message}}

+
diff --git a/src/demo-app/menu/menu-demo.html b/src/demo-app/menu/menu-demo.html index 2117fa4bc653..8ce48c1c392c 100644 --- a/src/demo-app/menu/menu-demo.html +++ b/src/demo-app/menu/menu-demo.html @@ -14,6 +14,24 @@ +