From 860875193e90baf209616eb3231108a11fc68938 Mon Sep 17 00:00:00 2001 From: Kristiyan Kostadinov Date: Fri, 18 Apr 2025 09:07:24 +0200 Subject: [PATCH] docs: remove noop module from harness examples Removes the `NoopAnimationsModule` from the harness examples since it isn't necessary for most of them. The rest of the examples have been switched to our token for disabling animations. --- .../autocomplete-harness-example.spec.ts | 5 ----- .../bottom-sheet-harness-example.spec.ts | 5 ++--- .../datepicker-harness/datepicker-harness-example.spec.ts | 7 +++---- .../dialog/dialog-harness/dialog-harness-example.spec.ts | 4 ++-- .../expansion-harness/expansion-harness-example.spec.ts | 4 ---- .../form-field-harness/form-field-harness-example.spec.ts | 4 ---- .../input/input-harness/input-harness-example.spec.ts | 4 ---- .../menu/menu-harness/menu-harness-example.spec.ts | 5 ++--- .../paginator-harness/paginator-harness-example.spec.ts | 5 ----- .../select/select-harness/select-harness-example.spec.ts | 5 ++--- .../sidenav-harness/sidenav-harness-example.spec.ts | 5 ----- .../snack-bar-harness/snack-bar-harness-example.spec.ts | 4 ++-- .../sort/sort-harness/sort-harness-example.spec.ts | 4 ---- .../stepper-harness/stepper-harness-example.spec.ts | 4 ---- .../tab-group-harness/tab-group-harness-example.spec.ts | 4 ---- .../timepicker-harness/timepicker-harness-example.spec.ts | 8 +++++--- .../tooltip-harness/tooltip-harness-example.spec.ts | 5 ++--- 17 files changed, 20 insertions(+), 62 deletions(-) diff --git a/src/components-examples/material/autocomplete/autocomplete-harness/autocomplete-harness-example.spec.ts b/src/components-examples/material/autocomplete/autocomplete-harness/autocomplete-harness-example.spec.ts index f58dab2d92da..7cb8bee825cb 100644 --- a/src/components-examples/material/autocomplete/autocomplete-harness/autocomplete-harness-example.spec.ts +++ b/src/components-examples/material/autocomplete/autocomplete-harness/autocomplete-harness-example.spec.ts @@ -3,17 +3,12 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; import {MatAutocompleteHarness} from '@angular/material/autocomplete/testing'; import {HarnessLoader} from '@angular/cdk/testing'; import {AutocompleteHarnessExample} from './autocomplete-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; -import {MatAutocompleteModule} from '@angular/material/autocomplete'; describe('AutocompleteHarnessExample', () => { let fixture: ComponentFixture; let loader: HarnessLoader; beforeEach(() => { - TestBed.configureTestingModule({ - imports: [MatAutocompleteModule, NoopAnimationsModule], - }); fixture = TestBed.createComponent(AutocompleteHarnessExample); fixture.detectChanges(); loader = TestbedHarnessEnvironment.loader(fixture); diff --git a/src/components-examples/material/bottom-sheet/bottom-sheet-harness/bottom-sheet-harness-example.spec.ts b/src/components-examples/material/bottom-sheet/bottom-sheet-harness/bottom-sheet-harness-example.spec.ts index e592441add3c..d3a9854abd67 100644 --- a/src/components-examples/material/bottom-sheet/bottom-sheet-harness/bottom-sheet-harness-example.spec.ts +++ b/src/components-examples/material/bottom-sheet/bottom-sheet-harness/bottom-sheet-harness-example.spec.ts @@ -3,8 +3,7 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; import {MatBottomSheetHarness} from '@angular/material/bottom-sheet/testing'; import {HarnessLoader} from '@angular/cdk/testing'; import {BottomSheetHarnessExample} from './bottom-sheet-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; -import {MatBottomSheetModule} from '@angular/material/bottom-sheet'; +import {MATERIAL_ANIMATIONS} from '@angular/material/core'; describe('BottomSheetHarnessExample', () => { let fixture: ComponentFixture; @@ -12,7 +11,7 @@ describe('BottomSheetHarnessExample', () => { beforeEach(() => { TestBed.configureTestingModule({ - imports: [MatBottomSheetModule, NoopAnimationsModule], + providers: [{provide: MATERIAL_ANIMATIONS, useValue: {animationsDisabled: true}}], }); fixture = TestBed.createComponent(BottomSheetHarnessExample); fixture.detectChanges(); diff --git a/src/components-examples/material/datepicker/datepicker-harness/datepicker-harness-example.spec.ts b/src/components-examples/material/datepicker/datepicker-harness/datepicker-harness-example.spec.ts index 72f8f5faa41a..a2ddcd06ea03 100644 --- a/src/components-examples/material/datepicker/datepicker-harness/datepicker-harness-example.spec.ts +++ b/src/components-examples/material/datepicker/datepicker-harness/datepicker-harness-example.spec.ts @@ -3,9 +3,7 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; import {MatDatepickerInputHarness} from '@angular/material/datepicker/testing'; import {HarnessLoader} from '@angular/cdk/testing'; import {DatepickerHarnessExample} from './datepicker-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; -import {MatDatepickerModule} from '@angular/material/datepicker'; -import {MatNativeDateModule} from '@angular/material/core'; +import {MATERIAL_ANIMATIONS, MatNativeDateModule} from '@angular/material/core'; describe('DatepickerHarnessExample', () => { let fixture: ComponentFixture; @@ -13,7 +11,8 @@ describe('DatepickerHarnessExample', () => { beforeEach(() => { TestBed.configureTestingModule({ - imports: [MatDatepickerModule, NoopAnimationsModule, MatNativeDateModule], + imports: [MatNativeDateModule], + providers: [{provide: MATERIAL_ANIMATIONS, useValue: {animationsDisabled: true}}], }); fixture = TestBed.createComponent(DatepickerHarnessExample); fixture.detectChanges(); diff --git a/src/components-examples/material/dialog/dialog-harness/dialog-harness-example.spec.ts b/src/components-examples/material/dialog/dialog-harness/dialog-harness-example.spec.ts index 58943abfa8fd..516e00f54ccb 100644 --- a/src/components-examples/material/dialog/dialog-harness/dialog-harness-example.spec.ts +++ b/src/components-examples/material/dialog/dialog-harness/dialog-harness-example.spec.ts @@ -1,9 +1,9 @@ import {ComponentFixture, TestBed} from '@angular/core/testing'; import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; +import {MATERIAL_ANIMATIONS} from '@angular/material/core'; import {MatDialogHarness} from '@angular/material/dialog/testing'; import {HarnessLoader} from '@angular/cdk/testing'; import {DialogHarnessExample} from './dialog-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; describe('DialogHarnessExample', () => { let fixture: ComponentFixture; @@ -11,7 +11,7 @@ describe('DialogHarnessExample', () => { beforeEach(() => { TestBed.configureTestingModule({ - imports: [NoopAnimationsModule], + providers: [{provide: MATERIAL_ANIMATIONS, useValue: {animationsDisabled: true}}], }); fixture = TestBed.createComponent(DialogHarnessExample); fixture.detectChanges(); diff --git a/src/components-examples/material/expansion/expansion-harness/expansion-harness-example.spec.ts b/src/components-examples/material/expansion/expansion-harness/expansion-harness-example.spec.ts index f08ba713a939..b2428b5e8b02 100644 --- a/src/components-examples/material/expansion/expansion-harness/expansion-harness-example.spec.ts +++ b/src/components-examples/material/expansion/expansion-harness/expansion-harness-example.spec.ts @@ -2,7 +2,6 @@ import {ComponentFixture, TestBed} from '@angular/core/testing'; import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; import {MatAccordionHarness, MatExpansionPanelHarness} from '@angular/material/expansion/testing'; import {HarnessLoader} from '@angular/cdk/testing'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; import {ExpansionHarnessExample} from './expansion-harness-example'; describe('ExpansionHarnessExample', () => { @@ -10,9 +9,6 @@ describe('ExpansionHarnessExample', () => { let loader: HarnessLoader; beforeEach(() => { - TestBed.configureTestingModule({ - imports: [NoopAnimationsModule], - }); fixture = TestBed.createComponent(ExpansionHarnessExample); fixture.detectChanges(); loader = TestbedHarnessEnvironment.loader(fixture); diff --git a/src/components-examples/material/form-field/form-field-harness/form-field-harness-example.spec.ts b/src/components-examples/material/form-field/form-field-harness/form-field-harness-example.spec.ts index 74e58d9cac81..059474cab0bf 100644 --- a/src/components-examples/material/form-field/form-field-harness/form-field-harness-example.spec.ts +++ b/src/components-examples/material/form-field/form-field-harness/form-field-harness-example.spec.ts @@ -3,7 +3,6 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; import {MatFormFieldHarness} from '@angular/material/form-field/testing'; import {HarnessLoader} from '@angular/cdk/testing'; import {FormFieldHarnessExample} from './form-field-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; import {MatInputHarness} from '@angular/material/input/testing'; describe('FormFieldHarnessExample', () => { @@ -11,9 +10,6 @@ describe('FormFieldHarnessExample', () => { let loader: HarnessLoader; beforeEach(() => { - TestBed.configureTestingModule({ - imports: [NoopAnimationsModule], - }); fixture = TestBed.createComponent(FormFieldHarnessExample); fixture.detectChanges(); loader = TestbedHarnessEnvironment.loader(fixture); diff --git a/src/components-examples/material/input/input-harness/input-harness-example.spec.ts b/src/components-examples/material/input/input-harness/input-harness-example.spec.ts index bb5a817e61da..825c0f727de5 100644 --- a/src/components-examples/material/input/input-harness/input-harness-example.spec.ts +++ b/src/components-examples/material/input/input-harness/input-harness-example.spec.ts @@ -3,16 +3,12 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; import {MatInputHarness} from '@angular/material/input/testing'; import {HarnessLoader} from '@angular/cdk/testing'; import {InputHarnessExample} from './input-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; describe('InputHarnessExample', () => { let fixture: ComponentFixture; let loader: HarnessLoader; beforeEach(() => { - TestBed.configureTestingModule({ - imports: [NoopAnimationsModule], - }); fixture = TestBed.createComponent(InputHarnessExample); fixture.detectChanges(); loader = TestbedHarnessEnvironment.loader(fixture); diff --git a/src/components-examples/material/menu/menu-harness/menu-harness-example.spec.ts b/src/components-examples/material/menu/menu-harness/menu-harness-example.spec.ts index 0015e75c1987..ab9f9adea3a2 100644 --- a/src/components-examples/material/menu/menu-harness/menu-harness-example.spec.ts +++ b/src/components-examples/material/menu/menu-harness/menu-harness-example.spec.ts @@ -2,9 +2,8 @@ import {ComponentFixture, TestBed} from '@angular/core/testing'; import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; import {MatMenuHarness} from '@angular/material/menu/testing'; import {HarnessLoader} from '@angular/cdk/testing'; -import {MatMenuModule} from '@angular/material/menu'; +import {MATERIAL_ANIMATIONS} from '@angular/material/core'; import {MenuHarnessExample} from './menu-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; describe('MenuHarnessExample', () => { let fixture: ComponentFixture; @@ -12,7 +11,7 @@ describe('MenuHarnessExample', () => { beforeEach(() => { TestBed.configureTestingModule({ - imports: [MatMenuModule, NoopAnimationsModule, MenuHarnessExample], + providers: [{provide: MATERIAL_ANIMATIONS, useValue: {animationsDisabled: true}}], }); fixture = TestBed.createComponent(MenuHarnessExample); fixture.detectChanges(); diff --git a/src/components-examples/material/paginator/paginator-harness/paginator-harness-example.spec.ts b/src/components-examples/material/paginator/paginator-harness/paginator-harness-example.spec.ts index ae343a8ce795..aae7ba53f0d5 100644 --- a/src/components-examples/material/paginator/paginator-harness/paginator-harness-example.spec.ts +++ b/src/components-examples/material/paginator/paginator-harness/paginator-harness-example.spec.ts @@ -3,8 +3,6 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; import {MatPaginatorHarness} from '@angular/material/paginator/testing'; import {HarnessLoader} from '@angular/cdk/testing'; import {PaginatorHarnessExample} from './paginator-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; -import {MatPaginatorModule} from '@angular/material/paginator'; describe('PaginatorHarnessExample', () => { let fixture: ComponentFixture; @@ -12,9 +10,6 @@ describe('PaginatorHarnessExample', () => { let instance: PaginatorHarnessExample; beforeEach(() => { - TestBed.configureTestingModule({ - imports: [MatPaginatorModule, NoopAnimationsModule], - }); fixture = TestBed.createComponent(PaginatorHarnessExample); fixture.detectChanges(); loader = TestbedHarnessEnvironment.loader(fixture); diff --git a/src/components-examples/material/select/select-harness/select-harness-example.spec.ts b/src/components-examples/material/select/select-harness/select-harness-example.spec.ts index 6b3008ce78fc..9d09732f9a26 100644 --- a/src/components-examples/material/select/select-harness/select-harness-example.spec.ts +++ b/src/components-examples/material/select/select-harness/select-harness-example.spec.ts @@ -1,10 +1,9 @@ import {ComponentFixture, TestBed} from '@angular/core/testing'; import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; import {MatSelectHarness} from '@angular/material/select/testing'; +import {MATERIAL_ANIMATIONS} from '@angular/material/core'; import {HarnessLoader} from '@angular/cdk/testing'; import {SelectHarnessExample} from './select-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; -import {MatSelectModule} from '@angular/material/select'; describe('SelectHarnessExample', () => { let fixture: ComponentFixture; @@ -12,7 +11,7 @@ describe('SelectHarnessExample', () => { beforeEach(() => { TestBed.configureTestingModule({ - imports: [MatSelectModule, NoopAnimationsModule], + providers: [{provide: MATERIAL_ANIMATIONS, useValue: {animationsDisabled: true}}], }); fixture = TestBed.createComponent(SelectHarnessExample); fixture.detectChanges(); diff --git a/src/components-examples/material/sidenav/sidenav-harness/sidenav-harness-example.spec.ts b/src/components-examples/material/sidenav/sidenav-harness/sidenav-harness-example.spec.ts index 95c79753d136..01a388b49978 100644 --- a/src/components-examples/material/sidenav/sidenav-harness/sidenav-harness-example.spec.ts +++ b/src/components-examples/material/sidenav/sidenav-harness/sidenav-harness-example.spec.ts @@ -7,17 +7,12 @@ import { } from '@angular/material/sidenav/testing'; import {HarnessLoader} from '@angular/cdk/testing'; import {SidenavHarnessExample} from './sidenav-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; describe('SidenavHarnessExample', () => { let fixture: ComponentFixture; let loader: HarnessLoader; beforeEach(() => { - TestBed.configureTestingModule({ - imports: [NoopAnimationsModule], - }); - fixture = TestBed.createComponent(SidenavHarnessExample); fixture.detectChanges(); loader = TestbedHarnessEnvironment.loader(fixture); diff --git a/src/components-examples/material/snack-bar/snack-bar-harness/snack-bar-harness-example.spec.ts b/src/components-examples/material/snack-bar/snack-bar-harness/snack-bar-harness-example.spec.ts index 79124ee65578..20d110959893 100644 --- a/src/components-examples/material/snack-bar/snack-bar-harness/snack-bar-harness-example.spec.ts +++ b/src/components-examples/material/snack-bar/snack-bar-harness/snack-bar-harness-example.spec.ts @@ -1,8 +1,8 @@ import {ComponentFixture, TestBed} from '@angular/core/testing'; import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; +import {MATERIAL_ANIMATIONS} from '@angular/material/core'; import {HarnessLoader} from '@angular/cdk/testing'; import {SnackBarHarnessExample} from './snack-bar-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; import {MatSnackBarHarness} from '@angular/material/snack-bar/testing'; describe('SnackBarHarnessExample', () => { @@ -11,7 +11,7 @@ describe('SnackBarHarnessExample', () => { beforeEach(() => { TestBed.configureTestingModule({ - imports: [NoopAnimationsModule], + providers: [{provide: MATERIAL_ANIMATIONS, useValue: {animationsDisabled: true}}], }); fixture = TestBed.createComponent(SnackBarHarnessExample); fixture.detectChanges(); diff --git a/src/components-examples/material/sort/sort-harness/sort-harness-example.spec.ts b/src/components-examples/material/sort/sort-harness/sort-harness-example.spec.ts index 4dded206b073..ae9a11560749 100644 --- a/src/components-examples/material/sort/sort-harness/sort-harness-example.spec.ts +++ b/src/components-examples/material/sort/sort-harness/sort-harness-example.spec.ts @@ -3,16 +3,12 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; import {MatSortHarness} from '@angular/material/sort/testing'; import {HarnessLoader, parallel} from '@angular/cdk/testing'; import {SortHarnessExample} from './sort-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; describe('SortHarnessExample', () => { let fixture: ComponentFixture; let loader: HarnessLoader; beforeEach(() => { - TestBed.configureTestingModule({ - imports: [NoopAnimationsModule], - }); fixture = TestBed.createComponent(SortHarnessExample); fixture.detectChanges(); loader = TestbedHarnessEnvironment.loader(fixture); diff --git a/src/components-examples/material/stepper/stepper-harness/stepper-harness-example.spec.ts b/src/components-examples/material/stepper/stepper-harness/stepper-harness-example.spec.ts index ac0a4ba48213..d24b2210929d 100644 --- a/src/components-examples/material/stepper/stepper-harness/stepper-harness-example.spec.ts +++ b/src/components-examples/material/stepper/stepper-harness/stepper-harness-example.spec.ts @@ -3,16 +3,12 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; import {MatStepperHarness, MatStepperNextHarness} from '@angular/material/stepper/testing'; import {HarnessLoader, parallel} from '@angular/cdk/testing'; import {StepperHarnessExample} from './stepper-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; describe('StepperHarnessExample', () => { let fixture: ComponentFixture; let loader: HarnessLoader; beforeEach(() => { - TestBed.configureTestingModule({ - imports: [NoopAnimationsModule], - }); fixture = TestBed.createComponent(StepperHarnessExample); fixture.detectChanges(); loader = TestbedHarnessEnvironment.loader(fixture); diff --git a/src/components-examples/material/tabs/tab-group-harness/tab-group-harness-example.spec.ts b/src/components-examples/material/tabs/tab-group-harness/tab-group-harness-example.spec.ts index fd61f739af85..a8ae34019fe5 100644 --- a/src/components-examples/material/tabs/tab-group-harness/tab-group-harness-example.spec.ts +++ b/src/components-examples/material/tabs/tab-group-harness/tab-group-harness-example.spec.ts @@ -3,16 +3,12 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; import {MatTabGroupHarness} from '@angular/material/tabs/testing'; import {HarnessLoader} from '@angular/cdk/testing'; import {TabGroupHarnessExample} from './tab-group-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; describe('TabGroupHarnessExample', () => { let fixture: ComponentFixture; let loader: HarnessLoader; beforeEach(() => { - TestBed.configureTestingModule({ - imports: [NoopAnimationsModule], - }); fixture = TestBed.createComponent(TabGroupHarnessExample); fixture.detectChanges(); loader = TestbedHarnessEnvironment.loader(fixture); diff --git a/src/components-examples/material/timepicker/timepicker-harness/timepicker-harness-example.spec.ts b/src/components-examples/material/timepicker/timepicker-harness/timepicker-harness-example.spec.ts index 332491f6f617..b990e968beb8 100644 --- a/src/components-examples/material/timepicker/timepicker-harness/timepicker-harness-example.spec.ts +++ b/src/components-examples/material/timepicker/timepicker-harness/timepicker-harness-example.spec.ts @@ -3,15 +3,17 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; import {MatTimepickerInputHarness} from '@angular/material/timepicker/testing'; import {HarnessLoader} from '@angular/cdk/testing'; import {TimepickerHarnessExample} from './timepicker-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; -import {DateAdapter, MatNativeDateModule} from '@angular/material/core'; +import {DateAdapter, MATERIAL_ANIMATIONS, MatNativeDateModule} from '@angular/material/core'; describe('TimepickerHarnessExample', () => { let fixture: ComponentFixture; let loader: HarnessLoader; beforeEach(() => { - TestBed.configureTestingModule({imports: [NoopAnimationsModule, MatNativeDateModule]}); + TestBed.configureTestingModule({ + imports: [MatNativeDateModule], + providers: [{provide: MATERIAL_ANIMATIONS, useValue: {animationsDisabled: true}}], + }); TestBed.inject(DateAdapter).setLocale('en-US'); // Set the locale to en-US to guarantee consistent tests. fixture = TestBed.createComponent(TimepickerHarnessExample); fixture.detectChanges(); diff --git a/src/components-examples/material/tooltip/tooltip-harness/tooltip-harness-example.spec.ts b/src/components-examples/material/tooltip/tooltip-harness/tooltip-harness-example.spec.ts index e46f2c647edd..0d1ca238a1d8 100644 --- a/src/components-examples/material/tooltip/tooltip-harness/tooltip-harness-example.spec.ts +++ b/src/components-examples/material/tooltip/tooltip-harness/tooltip-harness-example.spec.ts @@ -1,10 +1,9 @@ import {ComponentFixture, TestBed} from '@angular/core/testing'; import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed'; import {MatTooltipHarness} from '@angular/material/tooltip/testing'; +import {MATERIAL_ANIMATIONS} from '@angular/material/core'; import {HarnessLoader} from '@angular/cdk/testing'; import {TooltipHarnessExample} from './tooltip-harness-example'; -import {NoopAnimationsModule} from '@angular/platform-browser/animations'; -import {MatTooltipModule} from '@angular/material/tooltip'; describe('TooltipHarnessExample', () => { let fixture: ComponentFixture; @@ -12,7 +11,7 @@ describe('TooltipHarnessExample', () => { beforeEach(() => { TestBed.configureTestingModule({ - imports: [MatTooltipModule, NoopAnimationsModule], + providers: [{provide: MATERIAL_ANIMATIONS, useValue: {animationsDisabled: true}}], }); fixture = TestBed.createComponent(TooltipHarnessExample); fixture.detectChanges();