Skip to content

docs(changelog): clarify end of support for node-sass #21244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Dec 7, 2020

We deprecated support for node-sass in v10 with the intent of removing it
in v11, but we did not make this clear in the v11 changelog. This PR
clarifies that node-sass support is ended.

@jelbourn jelbourn added docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Dec 7, 2020
@jelbourn jelbourn requested review from crisbeto and mmalerba December 7, 2020 21:10
@jelbourn jelbourn requested a review from a team as a code owner December 7, 2020 21:10
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 7, 2020
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the CI is failing.

@jelbourn jelbourn force-pushed the changelog-node-sass branch from cc1e311 to 798fa9a Compare December 7, 2020 21:17
We deprecated support for node-sass in v10 with the intent of removing it
in v11, but we did not make this clear in the v11 changelog. This PR
clarifies that node-sass support is ended.
@jelbourn jelbourn force-pushed the changelog-node-sass branch from 798fa9a to 3a3067c Compare December 7, 2020 21:18
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Dec 7, 2020
@wagnermaciel wagnermaciel merged commit 62a5837 into angular:master Dec 8, 2020
wagnermaciel pushed a commit that referenced this pull request Dec 8, 2020
We deprecated support for node-sass in v10 with the intent of removing it
in v11, but we did not make this clear in the v11 changelog. This PR
clarifies that node-sass support is ended.

(cherry picked from commit 62a5837)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants