From 9ba5f0ca961c91c682364710606fbe87908b70e2 Mon Sep 17 00:00:00 2001 From: crisbeto Date: Tue, 19 Mar 2019 17:20:03 +0100 Subject: [PATCH] refactor(snack-bar): rework to account for ivy Reworks the snack bar to account for a breaking change in Ivy. --- src/lib/snack-bar/snack-bar-container.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/lib/snack-bar/snack-bar-container.ts b/src/lib/snack-bar/snack-bar-container.ts index 80ee734ec0bc..de006052e765 100644 --- a/src/lib/snack-bar/snack-bar-container.ts +++ b/src/lib/snack-bar/snack-bar-container.ts @@ -40,7 +40,11 @@ import {MatSnackBarConfig} from './snack-bar-config'; selector: 'snack-bar-container', templateUrl: 'snack-bar-container.html', styleUrls: ['snack-bar-container.css'], - changeDetection: ChangeDetectionStrategy.OnPush, + // In Ivy embedded views will be change detected from their declaration place, rather than + // where they were stamped out. This means that we can't have the snack bar container be OnPush, + // because it might cause snack bars that were opened from a template not to be out of date. + // tslint:disable-next-line:validate-decorators + changeDetection: ChangeDetectionStrategy.Default, encapsulation: ViewEncapsulation.None, animations: [matSnackBarAnimations.snackBarState], host: {