Skip to content

build: throw error if example is missing a title #15430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

crisbeto
Copy link
Member

Throws a proper error message if one of the examples is missing a title, in order to avoid a more cryptic error down the line.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 10, 2019
@crisbeto crisbeto force-pushed the build-error-missing-title branch from 346696e to ec357c5 Compare March 10, 2019 08:41
Throws a proper error message if one of the examples is missing a title, in order to avoid a more cryptic error down the line.
@crisbeto crisbeto force-pushed the build-error-missing-title branch from ec357c5 to 77752b2 Compare March 10, 2019 08:44
@crisbeto crisbeto marked this pull request as ready for review March 10, 2019 08:44
@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Mar 10, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 11, 2019
@mmalerba mmalerba merged commit c2f3d48 into angular:master Mar 11, 2019
mmalerba pushed a commit that referenced this pull request Mar 18, 2019
Throws a proper error message if one of the examples is missing a title, in order to avoid a more cryptic error down the line.
Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
Throws a proper error message if one of the examples is missing a title, in order to avoid a more cryptic error down the line.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants