From 35d5be7301d6bf522ef71b076b34270a7b44a7f7 Mon Sep 17 00:00:00 2001 From: crisbeto Date: Wed, 23 May 2018 23:04:27 +0200 Subject: [PATCH] chore: minor cleanup in icon tests and virtual scrolling * Removes a file that wasn't being used for anything under `cdk-experimental/scrolling`. * Enables `strictMetadataEmit` for the scrolling package. * Fixes a test for the icons which was leaking out a warning message. --- src/cdk-experimental/scrolling/tsconfig-build.json | 2 +- src/cdk-experimental/scrolling/typings.d.ts | 1 - src/lib/icon/icon.spec.ts | 4 ++-- 3 files changed, 3 insertions(+), 4 deletions(-) delete mode 100644 src/cdk-experimental/scrolling/typings.d.ts diff --git a/src/cdk-experimental/scrolling/tsconfig-build.json b/src/cdk-experimental/scrolling/tsconfig-build.json index 21ad182a0358..d94e5e159676 100644 --- a/src/cdk-experimental/scrolling/tsconfig-build.json +++ b/src/cdk-experimental/scrolling/tsconfig-build.json @@ -6,7 +6,7 @@ ], "angularCompilerOptions": { "annotateForClosureCompiler": true, - "strictMetadataEmit": false, // Workaround for Angular #22210 + "strictMetadataEmit": true, "flatModuleOutFile": "index.js", "flatModuleId": "@angular/cdk-experimental/scrolling", "skipTemplateCodegen": true, diff --git a/src/cdk-experimental/scrolling/typings.d.ts b/src/cdk-experimental/scrolling/typings.d.ts deleted file mode 100644 index ce4ae9b66cf0..000000000000 --- a/src/cdk-experimental/scrolling/typings.d.ts +++ /dev/null @@ -1 +0,0 @@ -declare var module: {id: string}; diff --git a/src/lib/icon/icon.spec.ts b/src/lib/icon/icon.spec.ts index 61a056e63e75..99f8d5a61bcc 100644 --- a/src/lib/icon/icon.spec.ts +++ b/src/lib/icon/icon.spec.ts @@ -428,9 +428,9 @@ describe('MatIcon', () => { })); it('should throw an error when using untrusted HTML', () => { - // Stub out console.error so we don't pollute our logs with Angular's warnings. + // Stub out console.warn so we don't pollute our logs with Angular's warnings. // Jasmine will tear the spy down at the end of the test. - spyOn(console, 'error'); + spyOn(console, 'warn'); expect(() => { iconRegistry.addSvgIconLiteral('circle', '');