Skip to content

fix(material/core): brand family not set for plain value #31260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2025
Merged

fix(material/core): brand family not set for plain value #31260

merged 1 commit into from
Jun 1, 2025

Conversation

crisbeto
Copy link
Member

If a non-map value is set for the typography, we were only setting the plain font family while the brand one was falling back to Roboto.

Fixes #31254.

@crisbeto
fix(material/core): brand family not set for plain value
033c8c7 
If a non-map value is set for the `typography`, we were only setting the plain font family while the brand one was falling back to Roboto.

Fixes angular#31254.
@crisbeto crisbeto requested a review from andrewseguin May 30, 2025 07:40
@crisbeto crisbeto requested a review from a team as a code owner May 30, 2025 07:40
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label May 30, 2025
@crisbeto crisbeto requested review from adolgachev and removed request for a team May 30, 2025 07:40
@crisbeto crisbeto removed the request for review from adolgachev June 1, 2025 05:33
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 1, 2025
@crisbeto crisbeto merged commit 8b821cb into angular:main Jun 1, 2025
29 checks passed
@crisbeto
Copy link
Member Author

crisbeto commented Jun 1, 2025

The changes were merged into the following branches: main, 20.0.x

crisbeto added a commit that referenced this pull request Jun 1, 2025
@crisbeto
fix(material/core): brand family not set for plain value (#31260)
45fcf24 
If a non-map value is set for the `typography`, we were only setting the plain font family while the brand one was falling back to Roboto.

Fixes #31254.

(cherry picked from commit 8b821cb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: material/core target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
2 participants
@crisbeto @andrewseguin