Skip to content

feat(material/slider): Support for multi word thumb label text #28599 #29489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(material/slider): Support for multi word thumb label text #28599 #29489

wants to merge 1 commit into from
+9 −0

Conversation

S-Prosper05
Copy link
Contributor

@S-Prosper05 S-Prosper05 commented Jul 26, 2024 •
edited
Loading

Fix Text Overflow in Value Indicator Container

Fixes #28599

Before:

Screenshot 2024-07-26 at 08 26 28

After:

Screenshot 2024-07-26 at 08 27 14

@S-Prosper05 S-Prosper05 requested a review from a team as a code owner July 26, 2024 06:32
@S-Prosper05 S-Prosper05 requested review from crisbeto and mmalerba and removed request for a team July 26, 2024 06:32
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jul 26, 2024
@wagnermaciel wagnermaciel added needs: discussion Further discussion with the team is needed before proceeding and removed needs: discussion Further discussion with the team is needed before proceeding labels Jul 31, 2024
@Wiggly8193
Copy link

Hi @crisbeto, May you please review this PR.

@amysorto amysorto self-assigned this Dec 17, 2024
@amysorto amysorto removed their assignment Jan 15, 2025
mmalerba
mmalerba requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running this against Google's internal tests, but there were some failures because this inadvertently removed the callout arrow. You can actually see this in the screenshots you posted:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalerba mmalerba mmalerba requested changes

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto is a code owner automatically assigned from angular/components-googlers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
detected: feature PR contains a feature commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(material/slider): Support for multi word thumb label text
5 participants
@S-Prosper05 @Wiggly8193 @mmalerba @amysorto @wagnermaciel