Skip to content

fix(cdk/table): row differ does not detect template changes #20765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(cdk/table): row differ does not detect template changes #20765

wants to merge 1 commit into from

Conversation

shlomiassaf
Copy link
Contributor

fixes #20717

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 11, 2020
@shlomiassaf
Copy link
Contributor Author

@jelbourn this is my attempt on this one, thanks!

@shlomiassaf shlomiassaf force-pushed the issue-20717 branch 2 times, most recently from 857e95d to f1254d9 Compare October 11, 2020 15:55
jelbourn
jelbourn reviewed Oct 12, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a couple minor comments

@jelbourn jelbourn added P2 The issue is important to a large percentage of users, with a workaround area: cdk/table P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release and removed P2 The issue is important to a large percentage of users, with a workaround labels Oct 12, 2020
jelbourn
jelbourn approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 19, 2020
@shlomiassaf
Copy link
Contributor Author

@jelbourn @andrewseguin This will get old eventually.

Can you review it?

Thanks...

@jelbourn
Copy link
Member

jelbourn commented Dec 1, 2020

Just took a look- seems like this got stalled because it's breaking ~10 targets inside of Google and nobody has had the time yet to dig into the failures and debug.

@mmalerba we should do a fresh run and see if the failures aren't too difficult to clear

@mmalerba
Copy link
Contributor

The errors don't look trivial to resolve. Some of the tests seem to be intentionally verifying that elements are not refreshed. I think we'll need to discuss with someone on that team to figure out what they're trying to accomplish and if we can make it work with this PR.

@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@andrewseguin
Copy link
Contributor

@shlomiassaf It's really tricky figuring out the internal test failures. If you'd like to rebase, we can continue to try and get them passing

@andrewseguin andrewseguin added needs: clarification The issue does not contain enough information for the team to determine if it is a real bug and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Mar 24, 2022
@viniciusschuelter viniciusschuelter mentioned this pull request Sep 13, 2022
Open
@josephperrott josephperrott added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed needs rebase labels Nov 16, 2022
@crisbeto
Copy link
Member

I'm closing this PR because there hasn't been any response to the latest comments in close to two years.

@crisbeto crisbeto closed this Feb 28, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker area: cdk/table cla: yes PR author has agreed to Google's Contributor License Agreement needs: clarification The issue does not contain enough information for the team to determine if it is a real bug target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(cdk-table): Row differ (trackBy) does not detect row template changes
7 participants
@shlomiassaf @jelbourn @mmalerba @andrewseguin @crisbeto @googlebot @josephperrott