fix(material/progress-bar): changing the value repaints other progress bars #23129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
reviewed
Jul 7, 2021
| @@ -61,6 +61,10 @@ $mat-progress-bar-piece-animation-duration: 250ms !default; | |||
| transform-origin: top left; | |||
| transition: transform $mat-progress-bar-piece-animation-duration ease; | |||
|
|
|||
| // Prevents elements from extra repainting due to `transition`. | |||
| will-change: transform; | |||
| z-index: 1; | |||
There was a problem hiding this comment.
I just tried it out, but I can see the other progress bars repainting even after these changes. Would it make sense to put a translateZ(0) on the parent instead? Also for what it's worth, I'm sure what performance implications this would have, considering that the element is relatively small and you usually only have one of them at a time.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new compositor layer to reduce repaint areas by providing
will-changeandz-index.Fixes #19873