fix(cdk/testing): Add support to send keys to conenteditable elements in testbed environment. #19107
Conversation
googlebot
added
the
cla: yes
mmalerba
changed the title
…s in testbed environment. Fixes angular#19102
ienzam
force-pushed
the
enzam-fix-19102
branch
from
775e6bc to
2d2d4a3
Compare
| await inheritEditable.sendKeys('Yi'); | ||
| // The following expectation is failing on Protractor environment | ||
| // In protractor environment, the text is empty. | ||
| if (environment == TestEnvironment.TEST_BED) { |
There was a problem hiding this comment.
We need to figure out why this is failing, not just disable the test
There was a problem hiding this comment.
Yeah, I understand that. Just wondering if you have any idea why this may be happening.
And even with this happening, if we can't find a solution, can we submit this CL?
(The CL is an improvement over current testbed implementation, this bug already exists in Protractor)
There was a problem hiding this comment.
I'd like to at least understand what's happening first. If we know why its happening I might be ok with submitting it as is (with a comment explaining).
Does the example work if you run it and manually interact? I'm not sure why its happening, but here are some guesses:
- Is the click handler on the design mode on button actually firing? Clicking is more finicky in Protractor, it can fail if other elements are overlapping or something like that
- Maybe it needs some delay before trying to edit? I'm not sure if the browser takes some time to activate design mode
There was a problem hiding this comment.
Sorry I am new here. How can I run the e2e test (as opposed to test) to interact with it to see what's happening?
There was a problem hiding this comment.
You should be able to run the end to end tests with yarn e2e and the unit tests with yarn test all
andrewseguin
removed
the
cla: yes
|
Closing due to inactivity from the author. If you'd like to continue with this PR, feel free to re-open a new rebased version |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #19102