Skip to content

WIP feat(progress-container): add progress-container component #13867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP feat(progress-container): add progress-container component #13867

wants to merge 1 commit into from

Conversation

CaerusKaru
Copy link
Member

  • Add two new components: mat-progress-container and mat-progress-content
    for use with new directive matProgress
  • When triggered, the matProgress directive will emit an event that notifies
    the components which will, if triggered to show the progress container, add
    that template to the view and hide the progress content, and otherwise remove
    the template from the view and show the progress content

Fixes #13667

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Oct 29, 2018
@CaerusKaru
Copy link
Member Author

Much thanks to @crisbeto for help with the design. The tests/docs are incomplete pending a final design review (a lot of the names, etc are bound to be changed).

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Oct 29, 2018
@CaerusKaru
Copy link
Member Author

Open design questions:

  • Should this be in the CDK since it's a pretty agnostic container?
  • Should the names be container/content like sidenav, or is it misleading?
  • Is this the best approach?

@CaerusKaru CaerusKaru force-pushed the adam/pc branch 3 times, most recently from 8d59106 to 2a957b3 Compare October 29, 2018 22:38
@CaerusKaru
feat(progress-container): add progress-container component
598823a 
* Add two new components: `mat-progress-container` and `mat-progress-content`
  for use with new directive `matProgress`
* When triggered, the `matProgress` directive will emit an event that notifies
  the components which will, if triggered to show the progress container, add
  that template to the view and hide the progress content, and otherwise remove
  the template from the view and show the progress content
@ngbot
Copy link

ngbot bot commented Nov 27, 2018

Hi @CaerusKaru! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@jpike88
Copy link

jpike88 commented May 9, 2019

Has this been abandoned?

@andrewseguin andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label May 30, 2019
@angajime
Copy link

Any update on this? Is there something we can do to help?

@jelbourn
Copy link
Member

We've decided not to move forward with this feature

@CaerusKaru CaerusKaru closed this Aug 21, 2019
@CaerusKaru CaerusKaru deleted the adam/pc branch August 21, 2019 20:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(mat-button): add progress-spinner option
7 participants
@CaerusKaru @googlebot @jpike88 @angajime @jelbourn @mmalerba @andrewseguin