Skip to content

Commit fd06b2e

Browse files
committed
fix(tree): rename Trigger to Toggle (#9317)
1 parent 00b9ee7 commit fd06b2e

File tree

10 files changed

+67
-67
lines changed

10 files changed

+67
-67
lines changed

src/cdk/tree/public-api.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ export * from './outlet';
1717
export * from './tree';
1818
export * from './tree-errors';
1919
export * from './tree-module';
20-
export * from './trigger';
20+
export * from './toggle';

src/cdk/tree/trigger.ts renamed to src/cdk/tree/toggle.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,25 +15,25 @@ import {CdkTree} from './tree';
1515
import {CdkTreeNode} from './node';
1616

1717
/**
18-
* Node trigger to expand/collapse the node.
18+
* Node toggle to expand/collapse the node.
1919
*/
2020
@Directive({
21-
selector: '[cdkTreeNodeTrigger]',
21+
selector: '[cdkTreeNodeToggle]',
2222
host: {
23-
'(click)': '_trigger($event)',
23+
'(click)': '_toggle($event)',
2424
}
2525
})
26-
export class CdkTreeNodeTrigger<T> {
26+
export class CdkTreeNodeToggle<T> {
2727
/** Whether expand/collapse the node recursively. */
28-
@Input('cdkTreeNodeTriggerRecursive')
28+
@Input('cdkTreeNodeToggleRecursive')
2929
get recursive(): boolean { return this._recursive; }
3030
set recursive(value: boolean) { this._recursive = coerceBooleanProperty(value); }
3131
protected _recursive = true;
3232

3333
constructor(protected _tree: CdkTree<T>,
3434
protected _treeNode: CdkTreeNode<T>) {}
3535

36-
_trigger(event: Event): void {
36+
_toggle(event: Event): void {
3737
this.recursive
3838
? this._tree.treeControl.toggleDescendants(this._treeNode.data)
3939
: this._tree.treeControl.toggle(this._treeNode.data);

src/cdk/tree/tree-module.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {CommonModule} from '@angular/common';
1111
import {NgModule} from '@angular/core';
1212
import {CdkTreeNodeOutlet} from './outlet';
1313
import {CdkTreeNodePadding} from './padding';
14-
import {CdkTreeNodeTrigger} from './trigger';
14+
import {CdkTreeNodeToggle} from './toggle';
1515
import {CdkTree} from './tree';
1616
import {CdkTreeNodeDef, CdkTreeNode} from './node';
1717
import {CdkNestedTreeNode} from './nested-node';
@@ -20,7 +20,7 @@ const EXPORTED_DECLARATIONS = [
2020
CdkNestedTreeNode,
2121
CdkTreeNodeDef,
2222
CdkTreeNodePadding,
23-
CdkTreeNodeTrigger,
23+
CdkTreeNodeToggle,
2424
CdkTree,
2525
CdkTreeNode,
2626
CdkTreeNodeOutlet,

src/cdk/tree/tree.spec.ts

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -94,13 +94,13 @@ describe('CdkTree', () => {
9494
});
9595
});
9696

97-
describe('with trigger', () => {
98-
let fixture: ComponentFixture<CdkTreeAppWithTrigger>;
99-
let component: CdkTreeAppWithTrigger;
97+
describe('with toggle', () => {
98+
let fixture: ComponentFixture<CdkTreeAppWithToggle>;
99+
let component: CdkTreeAppWithToggle;
100100

101101
beforeEach(() => {
102-
configureCdkTreeTestingModule([CdkTreeAppWithTrigger]);
103-
fixture = TestBed.createComponent(CdkTreeAppWithTrigger);
102+
configureCdkTreeTestingModule([CdkTreeAppWithToggle]);
103+
fixture = TestBed.createComponent(CdkTreeAppWithToggle);
104104

105105
component = fixture.componentInstance;
106106
dataSource = component.dataSource as FakeDataSource;
@@ -116,7 +116,7 @@ describe('CdkTree', () => {
116116
expect(component.treeControl.expansionModel.selected.length)
117117
.toBe(0, `Expect no expanded node`);
118118

119-
component.triggerRecursively = false;
119+
component.toggleRecursively = false;
120120
let data = dataSource.data;
121121
dataSource.addChild(data[2]);
122122
fixture.detectChanges();
@@ -348,13 +348,13 @@ describe('CdkTree', () => {
348348
});
349349
});
350350

351-
describe('with trigger', () => {
352-
let fixture: ComponentFixture<NestedCdkTreeAppWithTrigger>;
353-
let component: NestedCdkTreeAppWithTrigger;
351+
describe('with toggle', () => {
352+
let fixture: ComponentFixture<NestedCdkTreeAppWithToggle>;
353+
let component: NestedCdkTreeAppWithToggle;
354354

355355
beforeEach(() => {
356-
configureCdkTreeTestingModule([NestedCdkTreeAppWithTrigger]);
357-
fixture = TestBed.createComponent(NestedCdkTreeAppWithTrigger);
356+
configureCdkTreeTestingModule([NestedCdkTreeAppWithToggle]);
357+
fixture = TestBed.createComponent(NestedCdkTreeAppWithToggle);
358358

359359
component = fixture.componentInstance;
360360
dataSource = component.dataSource as FakeDataSource;
@@ -365,7 +365,7 @@ describe('CdkTree', () => {
365365
});
366366

367367
it('should expand/collapse the node', () => {
368-
component.triggerRecursively = false;
368+
component.toggleRecursively = false;
369369
let data = dataSource.data;
370370
const child = dataSource.addChild(data[1], false);
371371
dataSource.addChild(child, false);
@@ -600,7 +600,7 @@ function expectNestedTreeToMatch(treeElement: Element, ...expectedTree: any[]) {
600600
<cdk-tree [dataSource]="dataSource" [treeControl]="treeControl">
601601
<cdk-tree-node *cdkTreeNodeDef="let node" class="customNodeClass"
602602
cdkTreeNodePadding [cdkTreeNodePaddingIndent]="28"
603-
cdkTreeNodeTrigger>
603+
cdkTreeNodeToggle>
604604
{{node.pizzaTopping}} - {{node.pizzaCheese}} + {{node.pizzaBase}}
605605
</cdk-tree-node>
606606
</cdk-tree>
@@ -670,14 +670,14 @@ class WhenNodeNestedCdkTreeApp {
670670
<cdk-tree [dataSource]="dataSource" [treeControl]="treeControl">
671671
<cdk-tree-node *cdkTreeNodeDef="let node" class="customNodeClass"
672672
cdkTreeNodePadding
673-
cdkTreeNodeTrigger [cdkTreeNodeTriggerRecursive]="triggerRecursively">
673+
cdkTreeNodeToggle [cdkTreeNodeToggleRecursive]="toggleRecursively">
674674
{{node.pizzaTopping}} - {{node.pizzaCheese}} + {{node.pizzaBase}}
675675
</cdk-tree-node>
676676
</cdk-tree>
677677
`
678678
})
679-
class CdkTreeAppWithTrigger {
680-
triggerRecursively: boolean = true;
679+
class CdkTreeAppWithToggle {
680+
toggleRecursively: boolean = true;
681681

682682
getLevel = (node: TestData) => node.level;
683683
isExpandable = (node: TestData) => node.children.length > 0;
@@ -692,7 +692,7 @@ class CdkTreeAppWithTrigger {
692692
template: `
693693
<cdk-tree [dataSource]="dataSource" [treeControl]="treeControl">
694694
<cdk-nested-tree-node *cdkTreeNodeDef="let node" class="customNodeClass"
695-
cdkTreeNodeTrigger [cdkTreeNodeTriggerRecursive]="triggerRecursively">
695+
cdkTreeNodeToggle [cdkTreeNodeToggleRecursive]="toggleRecursively">
696696
{{node.pizzaTopping}} - {{node.pizzaCheese}} + {{node.pizzaBase}}
697697
<div *ngIf="treeControl.isExpanded(node)">
698698
<ng-template cdkTreeNodeOutlet></ng-template>
@@ -701,8 +701,8 @@ class CdkTreeAppWithTrigger {
701701
</cdk-tree>
702702
`
703703
})
704-
class NestedCdkTreeAppWithTrigger {
705-
triggerRecursively: boolean = true;
704+
class NestedCdkTreeAppWithToggle {
705+
toggleRecursively: boolean = true;
706706

707707
getChildren = (node: TestData) => node.observableChildren;
708708

@@ -717,12 +717,12 @@ class NestedCdkTreeAppWithTrigger {
717717
<cdk-tree [dataSource]="dataSource" [treeControl]="treeControl">
718718
<cdk-tree-node *cdkTreeNodeDef="let node" class="customNodeClass"
719719
cdkTreeNodePadding [cdkTreeNodePaddingIndent]="28"
720-
cdkTreeNodeTrigger>
720+
cdkTreeNodeToggle>
721721
{{node.pizzaTopping}} - {{node.pizzaCheese}} + {{node.pizzaBase}}
722722
</cdk-tree-node>
723723
<cdk-tree-node *cdkTreeNodeDef="let node; when: isOddNode" class="customNodeClass"
724724
cdkTreeNodePadding [cdkTreeNodePaddingIndent]="28"
725-
cdkTreeNodeTrigger>
725+
cdkTreeNodeToggle>
726726
[{{node.pizzaTopping}}] - [{{node.pizzaCheese}}] + [{{node.pizzaBase}}]
727727
</cdk-tree-node>
728728
</cdk-tree>

src/demo-app/tree/tree-demo.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
<mat-card-header>Flattened tree</mat-card-header>
44

55
<mat-tree [dataSource]="dataSource" [treeControl]="treeControl">
6-
<mat-tree-node *matTreeNodeDef="let node" matTreeNodeTrigger matTreeNodePadding>
6+
<mat-tree-node *matTreeNodeDef="let node" matTreeNodeToggle matTreeNodePadding>
77
{{node.key}} : {{node.value}}
88
</mat-tree-node>
99

1010
<mat-tree-node *matTreeNodeDef="let node;when: hasChild" matTreeNodePadding>
11-
<button mat-icon-button matTreeNodeTrigger
11+
<button mat-icon-button matTreeNodeToggle
1212
[attr.aria-label]="'toggle ' + node.key">
1313
<mat-icon>
1414
{{treeControl.isExpanded(node) ? 'expand_more' : 'chevron_right'}}
@@ -26,7 +26,7 @@
2626
<mat-card-header>Nested tree</mat-card-header>
2727

2828
<mat-tree [dataSource]="nestedDataSource" [treeControl]="nestedTreeControl">
29-
<mat-tree-node *matTreeNodeDef="let node" matTreeNodeTrigger>
29+
<mat-tree-node *matTreeNodeDef="let node" matTreeNodeToggle>
3030
<li>
3131
<div>{{node.key}}: {{node.value}}</div>
3232
</li>
@@ -35,7 +35,7 @@
3535
<mat-nested-tree-node *matTreeNodeDef="let node; when: hasNestedChild">
3636
<li>
3737
<div class="mat-tree-node">
38-
<button mat-icon-button matTreeNodeTrigger
38+
<button mat-icon-button matTreeNodeToggle
3939
[attr.aria-label]="'toggle ' + node.key">
4040
<mat-icon>
4141
{{nestedTreeControl.isExpanded(node) ? 'expand_more' : 'chevron_right'}}

src/lib/tree/public-api.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ export * from './node';
1111
export * from './padding';
1212
export * from './tree';
1313
export * from './tree-module';
14-
export * from './trigger';
14+
export * from './toggle';

src/lib/tree/toggle.ts

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
/**
2+
* @license
3+
* Copyright Google LLC All Rights Reserved.
4+
*
5+
* Use of this source code is governed by an MIT-style license that can be
6+
* found in the LICENSE file at https://angular.io/license
7+
*/
8+
9+
import {Directive, Input} from '@angular/core';
10+
import {CdkTreeNodeToggle} from '@angular/cdk/tree';
11+
12+
/**
13+
* Wrapper for the CdkTree's toggle with Material design styles.
14+
*/
15+
@Directive({
16+
selector: '[matTreeNodeToggle]',
17+
host: {
18+
'(click)': '_toggle($event)',
19+
},
20+
providers: [{provide: CdkTreeNodeToggle, useExisting: MatTreeNodeToggle}]
21+
})
22+
export class MatTreeNodeToggle<T> extends CdkTreeNodeToggle<T> {
23+
@Input('matTreeNodeToggleRecursive') recursive: boolean = true;
24+
}

src/lib/tree/tree-module.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ import {CommonModule} from '@angular/common';
1313
import {MatCommonModule} from '@angular/material/core';
1414
import {MatNestedTreeNode, MatTreeNodeDef, MatTreeNode} from './node';
1515
import {MatTree} from './tree';
16-
import {MatTreeNodeTrigger} from './trigger';
16+
import {MatTreeNodeToggle} from './toggle';
1717
import {MatTreeNodeOutlet} from './outlet';
1818
import {MatTreeNodePadding} from './padding';
1919

2020
const MAT_TREE_DIRECTIVES = [
2121
MatNestedTreeNode,
2222
MatTreeNodeDef,
2323
MatTreeNodePadding,
24-
MatTreeNodeTrigger,
24+
MatTreeNodeToggle,
2525
MatTree,
2626
MatTreeNode,
2727
MatTreeNodeOutlet,

src/lib/tree/tree.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ represented in ways that would be difficult to accomplish with flat nodes.
5252

5353
The `<mat-tree>` itself only deals with the rendering of a tree structure.
5454
Additional features can be built on top of the tree by adding behavior inside node templates
55-
(e.g., padding and trigger). Interactions that affect the
55+
(e.g., padding and toggle). Interactions that affect the
5656
rendered data (such as expand/collapse) should be propagated through the table's data source.
5757

5858
### TreeControl
@@ -62,13 +62,13 @@ node recursively through tree control. For nested tree node, `getChildren` funct
6262
the `NestedTreeControl` to make it work recursively. For flattened tree node, `getLevel` and
6363
`isExpandable` functions need to pass to the `FlatTreeControl` to make it work recursively.
6464

65-
### Trigger
65+
### Toggle
6666

67-
A `matTreeNodeTrigger` can be added in the tree node template to expand/collapse the tree node. The
68-
trigger triggers the expand/collapse functions in `TreeControl` and is able to expand/collapse a
69-
tree node recursively by setting `[matTreeNodeTriggerRecursive]` to `true`.
67+
A `matTreeNodeToggle` can be added in the tree node template to expand/collapse the tree node. The
68+
toggle toggles the expand/collapse functions in `TreeControl` and is able to expand/collapse a
69+
tree node recursively by setting `[matTreeNodeToggleRecursive]` to `true`.
7070

71-
The trigger can be placed anywhere in the tree node, and is only triggered by `click` action.
71+
The toggle can be placed anywhere in the tree node, and is only toggled by `click` action.
7272

7373

7474
### Padding (Flat tree only)

src/lib/tree/trigger.ts

Lines changed: 0 additions & 24 deletions
This file was deleted.

0 commit comments

Comments
 (0)