Skip to content

Commit f46d7b3

Browse files
devversionjelbourn
authored andcommitted
build: enable strict attribute type checking (#17977)
When we initially enabled strict template type checking in the components repository, we temporarily disabled the strict attribute type checking due to an issue with `NgModel` and the disabled input. This has been fixed in the recent rc v9.0.0-rc.7
1 parent 8f62ffe commit f46d7b3

File tree

5 files changed

+8
-9
lines changed

5 files changed

+8
-9
lines changed

src/a11y-demo/dialog/dialog-neptune-a11y.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ <h2 mat-dialog-title>Neptune</h2>
2222
Read more on Wikipedia
2323
</a>
2424

25-
<button mat-button color="secondary" (click)="showInStackedDialog()">
25+
<button mat-button color="accent" (click)="showInStackedDialog()">
2626
Show in dialog</button>
2727
</mat-dialog-actions>

src/a11y-demo/progress-spinner/progress-spinner-a11y.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<section>
22
<h2>Loading indicator (Indeterminate progress spinner)</h2>
3-
<mat-spinner color="indeterminate" [strokeWidth]="1" aria-label="Loading"></mat-spinner>
3+
<mat-spinner mode="indeterminate" [strokeWidth]="1" aria-label="Loading"></mat-spinner>
44
<mat-spinner color="accent" aria-label="Loading"></mat-spinner>
55
</section>
66

src/universal-app/kitchen-sink-mdc/kitchen-sink-mdc.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,11 @@ <h2>Tabs</h2>
8686

8787
<nav mat-tab-nav-bar>
8888
<a mat-tab-link href="https://google.com">Google</a>
89-
<a mat-tab-link href="https://google.com" active>Also Google</a>
89+
<a mat-tab-link href="https://google.com" [active]="true">Also Google</a>
9090
</nav>
9191

9292
<h2>Progress bar</h2>
93-
<mat-progress-bar value="25"></mat-progress-bar>
94-
<mat-progress-bar mode="buffer" value="25" bufferValue="60"></mat-progress-bar>
93+
<mat-progress-bar [value]="25"></mat-progress-bar>
94+
<mat-progress-bar mode="buffer" [value]="25" [bufferValue]="60"></mat-progress-bar>
9595
<mat-progress-bar mode="indeterminate"></mat-progress-bar>
9696
<mat-progress-bar mode="query"></mat-progress-bar>

src/universal-app/kitchen-sink/kitchen-sink.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ <h2>Menu</h2>
157157
<h2>Progress bar</h2>
158158

159159
<mat-progress-bar value="25"></mat-progress-bar>
160-
<mat-progress-bar mode="buffer" value="25" bufferValue="60"></mat-progress-bar>
160+
<mat-progress-bar mode="buffer" value="25" [bufferValue]="60"></mat-progress-bar>
161161
<mat-progress-bar mode="indeterminate"></mat-progress-bar>
162162
<mat-progress-bar mode="query"></mat-progress-bar>
163163

@@ -225,7 +225,7 @@ <h2>Tabs</h2>
225225

226226
<nav mat-tab-nav-bar>
227227
<a mat-tab-link href="https://google.com">Google</a>
228-
<a mat-tab-link href="https://google.com" active>Also Google</a>
228+
<a mat-tab-link href="https://google.com" [active]="true">Also Google</a>
229229
</nav>
230230

231231
<h2>Paginator</h2>

tools/bazel/postinstall-patches.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ const fs = require('fs');
1212
* Version of the post install patch. Needs to be incremented when patches
1313
* have been added or removed.
1414
*/
15-
const PATCH_VERSION = 1;
15+
const PATCH_VERSION = 2;
1616

1717
/** Path to the project directory. */
1818
const projectDir = path.join(__dirname, '../..');
@@ -120,7 +120,6 @@ searchAndReplace(`[formatProperty + "_ivy_ngcc"]`, '[formatProperty]',
120120
searchAndReplace(/angular_compiler_options = {/, `$&
121121
"strictTemplates": True,
122122
"strictDomLocalRefTypes ": False,
123-
"strictAttributeTypes": False,
124123
"strictDomEventTypes": False,`, 'node_modules/@angular/bazel/src/ng_module.bzl');
125124

126125
// More info in https://github.com/angular/angular/pull/33786

0 commit comments

Comments
 (0)