Skip to content

Commit f1a33e9

Browse files
IgorMinartinayuangao
authored andcommitted
build: mark material and cdk packages as sideEffect-free for webpack v4 (#10816)
This change enables material and cdk packages to take advantage of webpacks more advanced optimizations documented at https://github.com/webpack/webpack/tree/master/examples/side-effects Our code is already side-effect free because otherwise @angular-devkit/build-optimizer would break it, so it's safe to turn this on.
1 parent dec91ce commit f1a33e9

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

src/cdk/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,6 @@
2828
},
2929
"dependencies": {
3030
"tslib": "^1.7.1"
31-
}
31+
},
32+
"sideEffects": false
3233
}

src/lib/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,6 @@
2929
"dependencies": {
3030
"tslib": "^1.7.1"
3131
},
32-
"schematics": "./schematics/collection.json"
32+
"schematics": "./schematics/collection.json",
33+
"sideEffects": false
3334
}

tools/package-tools/entry-point-package-json.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ export function createEntryPointPackageJson(destDir: string, packageName: string
1010
main: `../bundles/${packageName}-${entryPointName}.umd.js`,
1111
module: `../esm5/${entryPointName}.es5.js`,
1212
es2015: `../esm2015/${entryPointName}.js`,
13+
sideEffects: false,
1314
};
1415

1516
writeFileSync(join(destDir, 'package.json'), JSON.stringify(content, null, 2), 'utf-8');

0 commit comments

Comments
 (0)