Skip to content

Commit e8ea6fe

Browse files
committed
fix(multiple): address feedback
1 parent a752b8a commit e8ea6fe

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

src/material-experimental/mdc-checkbox/_checkbox-private.scss

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,4 @@ $private-checkbox-theme-config: map.merge(mdc-checkbox-theme.$light-theme, (
5050
unselected-icon-color: $border-color,
5151
unselected-pressed-icon-color: $border-color,
5252
));
53-
54-
// We don't inherit the border focus style from MDC since we don't use their ripple.
55-
// Instead we need to replicate it here.
56-
.mdc-checkbox__native-control {
57-
&:focus:enabled:not(:checked):not(:indeterminate):not([data-indeterminate=true]) {
58-
& ~ .mdc-checkbox__background {
59-
border-color: $active-border-color;
60-
}
61-
}
62-
}
6353
}

src/material-experimental/mdc-checkbox/checkbox.scss

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,16 @@
9090
display: none;
9191
}
9292

93+
// We don't inherit the border focus style from MDC since we don't use their ripple.
94+
// Instead we need to replicate it here.
95+
.mdc-checkbox__native-control {
96+
&:focus:enabled:not(:checked):not(:indeterminate):not([data-indeterminate=true]) {
97+
& ~ .mdc-checkbox__background {
98+
border-color: var(--mdc-checkbox-unselected-focus-icon-color, black);
99+
}
100+
}
101+
}
102+
93103
@include _ripple-base-styles();
94104
}
95105

src/material-experimental/mdc-radio/_radio-theme.scss

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,6 @@
5858
&.mat-warn {
5959
@include _color-palette($warn);
6060
}
61-
62-
// We don't inherit the border focus style from MDC since we don't use their ripple.
63-
// Instead we need to replicate it here.
64-
.mdc-radio .mdc-radio__native-control:focus:enabled:not(:checked) {
65-
& ~ .mdc-radio__background .mdc-radio__outer-circle {
66-
border-color: $active-border-color;
67-
}
68-
}
6961
}
7062
}
7163
}

src/material-experimental/mdc-radio/radio.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,14 @@
7676
transition: none !important;
7777
}
7878
}
79+
80+
// We don't inherit the border focus style from MDC since we don't use their ripple.
81+
// Instead we need to replicate it here.
82+
.mdc-radio .mdc-radio__native-control:focus:enabled:not(:checked) {
83+
& ~ .mdc-radio__background .mdc-radio__outer-circle {
84+
border-color: var(--mdc-radio-unselected-focus-icon-color, black);
85+
}
86+
}
7987
}
8088

8189
// Element used to provide a larger tap target for users on touch devices.

0 commit comments

Comments
 (0)