build: enable noImplicitReturns compiler option (#16672)

Turns on the `noImplicitReturns` compiler option and fixes any errors that show up as a result.

Fixes #16669.

Author: crisbeto

src/dev-app/tsconfig-aot.json

@@ -0,0 +1,45 @@
+// TypeScript config that extends the dev-app tsconfig file. This config compiles the
+// "main-aot.ts" file and also enables templage code generation / AOT.
+{
+  "extends": "./tsconfig-build",
+  "compilerOptions": {
+    // Needed for Moment.js since it doesn't have a default export.
+    "allowSyntheticDefaultImports": true,
+    "experimentalDecorators": true,
+    "noUnusedParameters": false,
+    "noUnusedLocals": false,
+    "strictNullChecks": true,
+    "noImplicitReturns": true,
+    "strictFunctionTypes": true,
+    "noImplicitAny": true,
+    "noImplicitThis": true,
+    "outDir": "../../dist/packages/dev-app",
+    "rootDirs": [
+      ".",
+      // Include the package output here because otherwise NGC won't be able to load
+      // the SCSS files.
+      "../../dist/packages/dev-app"
+    ],
+    "paths": {
+      "@angular/material/*": ["../../dist/releases/material/*"],
+      "@angular/cdk/*": ["../../dist/releases/cdk/*"],
+      "@angular/cdk": ["../../dist/releases/cdk"],
+      "@angular/material-experimental/*": ["../../dist/releases/material-experimental/*"],
+      "@angular/material-experimental": ["../../dist/releases/material-experimental"],
+      "@angular/cdk-experimental/*": ["../../dist/releases/cdk-experimental/*"],
+      "@angular/cdk-experimental": ["../../dist/releases/cdk-experimental"],
+      "@angular/material-moment-adapter": ["../../dist/releases/material-moment-adapter"],
+      "@angular/google-maps/*": ["../../dist/releases/google-maps/*"],
+      "@angular/material-examples": ["../../dist/releases/material-examples"]
+    }
+  },
+  "include": [
+    "./typings.d.ts",
+    "./main-aot.ts",
+    "**/*-module.ts"
+  ],
+  "angularCompilerOptions": {
+    "skipTemplateCodegen": false,
+    "fullTemplateTypeCheck": true
+  }
+}

src/dev-app/tsconfig-build.json

@@ -0,0 +1,50 @@
+// TypeScript config file that is used to compile the dev-app. Target environment will be ES5,
+// since the dev-app will be served in the browser.
+{
+  "compilerOptions": {
+    // Needed for Moment.js since it doesn't have a default export.
+    "allowSyntheticDefaultImports": true,
+    "declaration": false,
+    "emitDecoratorMetadata": true,
+    "experimentalDecorators": true,
+    "noUnusedParameters": false,
+    "noUnusedLocals": false,
+    "strictNullChecks": true,
+    "noImplicitReturns": true,
+    "strictFunctionTypes": true,
+    "noImplicitThis": true,
+    "lib": ["es6", "es2015", "dom"],
+    "skipLibCheck": true,
+    "module": "commonjs",
+    "moduleResolution": "node",
+    "noEmitOnError": true,
+    "noImplicitAny": true,
+    "outDir": "../../dist/packages/dev-app",
+    "sourceMap": true,
+    "target": "es5",
+    "stripInternal": false,
+    "typeRoots": [
+      "../../node_modules/@types/!(node)"
+    ],
+    "baseUrl": ".",
+    "paths": {
+      "@angular/material/*": ["../../dist/packages/material/*"],
+      "@angular/cdk/*": ["../../dist/packages/cdk/*"],
+      "@angular/cdk": ["../../dist/packages/cdk"],
+      "@angular/material-experimental/*": ["../../dist/packages/material-experimental/*"],
+      "@angular/material-experimental": ["../../dist/packages/material-experimental"],
+      "@angular/cdk-experimental/*": ["../../dist/packages/cdk-experimental/*"],
+      "@angular/cdk-experimental": ["../../dist/packages/cdk-experimental"],
+      "@angular/material-moment-adapter": ["../../dist/packages/material-moment-adapter"],
+      "@angular/google-maps/*": ["../../dist/packages/google-maps/*"],
+      "@angular/material-examples": ["../../dist/packages/material-examples"]
+    }
+  },
+  "include": [
+    "./typings.d.ts",
+    "./system-rxjs-operators.ts",
+    "./system-config.ts",
+    "./main.ts",
+    "**/*-module.ts"
+  ]
+}