Skip to content

Commit dc54b00

Browse files
devversionannieyw
authored andcommitted
build: setup default browser for running legacy tests locally (#20620)
Sometimes the legacy Karma tests might fail and one might want to debug those. Currently the Gulp task can be run for that, but it's not starting any browser so one needs to launch Chrome manually. Tests usually fail then because the browser has different dimensions but our test expectations rely on a specific dimension. i.e. 1024x768 (cherry picked from commit e8265cc)
1 parent 738ec02 commit dc54b00

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

test/karma-browsers.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@
66
"--no-sandbox"
77
]
88
},
9+
"ChromeLocalDebug": {
10+
"base": "Chrome",
11+
"flags": [
12+
"--window-size=1024,768"
13+
]
14+
},
915
"SAUCELABS_IOS13": {
1016
"base": "SauceLabs",
1117
"browserName": "Safari",

test/karma.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ module.exports = config => {
106106
browserDisconnectTolerance: 1,
107107
browserNoActivityTimeout: 300000,
108108

109-
browsers: [],
109+
browsers: ['ChromeLocalDebug'],
110110
singleRun: false,
111111

112112
// Try Websocket for a faster transmission first. Fallback to polling if necessary.

0 commit comments

Comments
 (0)