Skip to content

Commit da25796

Browse files
committed
fix(checkbox): model value not updated when using toggle method
Along the same lines as #11812. The checkbox doesn't update its `ControlValueAccessor` value when it is toggled via the `toggle` method.
1 parent 4b82786 commit da25796

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

src/material/checkbox/checkbox.spec.ts

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -874,7 +874,7 @@ describe('MatCheckbox', () => {
874874
let inputElement: HTMLInputElement;
875875
let ngModel: NgModel;
876876

877-
beforeEach(() => {
877+
beforeEach(fakeAsync(() => {
878878
fixture = createComponent(CheckboxWithNgModel);
879879

880880
fixture.componentInstance.isRequired = false;
@@ -885,7 +885,7 @@ describe('MatCheckbox', () => {
885885
checkboxInstance = checkboxDebugElement.componentInstance;
886886
inputElement = <HTMLInputElement>checkboxNativeElement.querySelector('input');
887887
ngModel = checkboxDebugElement.injector.get<NgModel>(NgModel);
888-
});
888+
}));
889889

890890
it('should be pristine, untouched, and valid initially', () => {
891891
expect(ngModel.valid).toBe(true);
@@ -984,6 +984,18 @@ describe('MatCheckbox', () => {
984984
expect(checkboxInstance.checked).toBe(false);
985985
expect(ngModel.valid).toBe(false);
986986
});
987+
988+
it('should updated the ngModel value when using the `toggle` method', fakeAsync(() => {
989+
const checkbox = fixture.debugElement.query(By.directive(MatCheckbox)).componentInstance;
990+
991+
expect(fixture.componentInstance.isGood).toBe(false);
992+
993+
checkbox.toggle();
994+
fixture.detectChanges();
995+
996+
expect(fixture.componentInstance.isGood).toBe(true);
997+
}));
998+
987999
});
9881000

9891001
describe('with name attribute', () => {

src/material/checkbox/checkbox.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -354,6 +354,7 @@ export class MatCheckbox extends _MatCheckboxMixinBase implements ControlValueAc
354354
/** Toggles the `checked` state of the checkbox. */
355355
toggle(): void {
356356
this.checked = !this.checked;
357+
this._controlValueAccessorChangeFn(this.checked);
357358
}
358359

359360
/**

0 commit comments

Comments
 (0)