Skip to content

Commit d2f7195

Browse files
devversionandrewseguin
authored andcommitted
build: update firefox to latest version
Updates our Firefox version that is used for Bazel unit tests to v78.0. Previously we were using v68. To update the Firefox version, we had to set up a custom Browser target with repositories as the version for Firefox is usually hard-coded in `rules_webtesting` and we cannot control that. See related change in the dev-infra package: angular/angular#38029.
1 parent 80e4d3f commit d2f7195

File tree

3 files changed

+2
-12
lines changed

3 files changed

+2
-12
lines changed

WORKSPACE

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -85,16 +85,6 @@ load("@io_bazel_rules_webtesting//web:repositories.bzl", "web_test_repositories"
8585

8686
web_test_repositories()
8787

88-
load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.2.bzl", "browser_repositories")
89-
90-
browser_repositories(
91-
# Chrome is brought in by `@npm_dev_infra_private` for better version control and
92-
# RBE experience where individual browser archives per platform are provided.
93-
# TODO: Do the same for Firefox (but it is not used for local development): DEV-114
94-
chromium = False,
95-
firefox = True,
96-
)
97-
9888
# Fetch transitive dependencies which are needed to use the Sass rules.
9989
load("@io_bazel_rules_sass//:package.bzl", "rules_sass_dependencies")
10090

scripts/run-component-tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ if (local && (components.length > 1 || all)) {
6161
process.exit(1);
6262
}
6363

64-
const browserName = firefox ? 'firefox-local' : 'chromium';
64+
const browserName = firefox ? 'firefox' : 'chromium';
6565
const bazelBinary = `yarn -s ${watch ? 'ibazel' : 'bazel'}`;
6666
const configFlag = viewEngine ? '--config=view-engine' : '';
6767

tools/defaults.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ def karma_web_test_suite(name, **kwargs):
166166
# Note: when changing the browser names here, also update the "yarn test"
167167
# script to reflect the new browser names.
168168
"@npm_angular_dev_infra_private//browsers/chromium:chromium",
169-
"@io_bazel_rules_webtesting//browsers:firefox-local",
169+
"@npm_angular_dev_infra_private//browsers/firefox:firefox",
170170
]
171171

172172
for opt_name in kwargs.keys():

0 commit comments

Comments
 (0)