build: use formatting tool from shared dev-infra package (#19592)

Removes our custom script/buildifier configuration. We will
be using the `ng-dev format` command that has builtin support
for buildifier (e.g with configured rules). Also it allows us
to format changed files

The motiviation is that we don't need to maintain multiple buildifier
configurations if there is one canonical one now available in the
shared dev-infra package.

Author: devversion

.circleci/config.yml

@@ -141,7 +141,7 @@ var_20: &only_on_pull_requests_filter
 # -----------------------------
 # Container version of CircleCI
 # -----------------------------
-version: 2
+version: 2.1
 
 # -----------------------------------------------------------------------------------------
 # Job definitions. Jobs which are defined just here, will not run automatically. Each job
@@ -309,7 +309,7 @@ jobs:
             bazel build //:entry_points_manifest
             yarn check-entry-point-setup $(bazel info bazel-bin)/entry_points_manifest.json
 
-      - run: ./scripts/circleci/lint-bazel-files.sh
+      - run: yarn ng-dev format changed --check << pipeline.git.base_revision >>
       - run: yarn ownerslint
       - run: yarn stylelint
       - run: yarn tslint

.ng-dev/config.ts

@@ -1,7 +1,9 @@
+import {format} from './format';
 import {github} from './github';
 import {merge} from './merge';
 
 module.exports = {
   github,
   merge,
+  format,
 };

.ng-dev/format.ts

@@ -0,0 +1,9 @@
+import {FormatConfig} from '@angular/dev-infra-private/format/config';
+
+/**
+ * Configuration for the ng-dev format command. We currently only use the buildifier
+ * formatter that is responsible for formatting Bazel build and `.bzl` files.
+ */
+export const format: FormatConfig = {
+  buildifier: true,
+};

package.json

@@ -15,8 +15,6 @@
   "scripts": {
     "postinstall": "node tools/postinstall/apply-patches.js && ngcc --properties module main --create-ivy-entry-points && node tools/postinstall/update-ngcc-main-fields.js",
     "build": "node ./scripts/build-packages-dist.js",
-    "bazel:buildifier": "find . -type f \\( -name \"*.bzl\" -or -name WORKSPACE -or -name BUILD -or -name BUILD.bazel \\) ! -path \"*/node_modules/*\" | xargs buildifier -v --warnings=attr-cfg,attr-license,attr-non-empty,attr-output-default,attr-single-file,constant-glob,ctx-args,depset-iteration,depset-union,dict-concatenation,duplicated-name,filetype,git-repository,http-archive,integer-division,load,load-on-top,native-build,native-package,output-group,package-name,package-on-top,redefined-variable,repository-name,same-origin-load,string-iteration,unused-variable,unsorted-dict-items,out-of-order-load",
-    "bazel:format-lint": "yarn -s bazel:buildifier --lint=warn --mode=check",
     "dev-app": "ibazel run //src/dev-app:devserver",
     "test": "node ./scripts/run-component-tests.js",
     "test-local": "yarn -s test --local",
@@ -33,9 +31,7 @@
     "check-rollup-globals": "ts-node --project scripts/tsconfig.json scripts/check-rollup-globals.ts",
     "changelog": "ts-node --project tools/release/tsconfig.json tools/release/changelog.ts",
     "preinstall": "node ./tools/npm/check-npm.js",
-    "format:ts": "git-clang-format HEAD $(git diff HEAD --name-only | grep -v \"\\.d\\.ts\")",
-    "format:bazel": "yarn -s bazel:buildifier --lint=fix --mode=fix",
-    "format": "yarn -s format:ts && yarn -s format:bazel",
+    "format": "yarn ng-dev format changed",
     "cherry-pick-patch": "ts-node --project tools/cherry-pick-patch/tsconfig.json tools/cherry-pick-patch/cherry-pick-patch.ts",
     "ownerslint": "ts-node --project scripts/tsconfig.json scripts/ownerslint.ts",
     "tslint": "tslint -c tslint.json --project ./tsconfig.json",
@@ -111,7 +107,6 @@
     "axe-webdriverjs": "^1.1.1",
     "browser-sync": "^2.26.7",
     "chalk": "^2.4.2",
-    "clang-format": "^1.2.4",
     "codelyzer": "^6.0.0-next.1",
     "conventional-changelog": "^3.0.5",
     "dgeni": "^0.4.11",

scripts/circleci/lint-bazel-files.sh

@@ -3034,15 +3034,6 @@ cjson@^0.3.1:
   dependencies:
     json-parse-helpfulerror "^1.0.3"
 
-clang-format@^1.2.4:
-  version "1.2.4"
-  resolved "https://registry.yarnpkg.com/clang-format/-/clang-format-1.2.4.tgz#4bb4b0a98180428deb093cf20982e9fc1af20b6c"
-  integrity sha512-sw+nrGUp3hvmANd1qF8vZPuezSYQAiXgGBiEtkXTtJnnu6b00fCqkkDIsnRKrNgg4nv6NYZE92ejvOMIXZoejw==
-  dependencies:
-    async "^1.5.2"
-    glob "^7.0.0"
-    resolve "^1.1.6"
-
 class-utils@^0.3.5:
   version "0.3.6"
   resolved "https://registry.yarnpkg.com/class-utils/-/class-utils-0.3.6.tgz#f93369ae8b9a7ce02fd41faad0ca83033190c463"