Skip to content

Commit bbe403b

Browse files
committed
remove some TODOs that are no longer issues
1 parent 0914d84 commit bbe403b

File tree

4 files changed

+4
-15
lines changed

4 files changed

+4
-15
lines changed

src/cdk-experimental/testing/protractor.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
// TODO(mmalerba): Should this file be part of `@angular/cdk-experimental/testing` or a separate
10-
// package? It depends on protractor which we don't want to put in the deps for cdk-experimental.
11-
129
import {browser, by, element as protractorElement, ElementFinder} from 'protractor';
1310

1411
import {

src/cdk-experimental/testing/testbed.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
// TODO(mmalerba): Should this file be part of `@angular/cdk-experimental/testing` or a separate
10-
// package? It depends on `@angular/core/testing` which we don't want to put in the deps for
11-
// cdk-experimental.
12-
139
import {
1410
dispatchFakeEvent,
1511
dispatchKeyboardEvent,

src/cdk-experimental/testing/tests/test-main-component.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,11 @@ export class TestMainComponent {
3030
username: string;
3131
counter: number;
3232
asyncCounter: number;
33-
// TODO: remove '!'.
34-
input!: string;
33+
input: string;
3534
memo: string;
3635
testTools: string[];
3736
testMethods: string[];
38-
// TODO: remove '!'.
39-
_isHovering!: boolean;
37+
_isHovering: boolean;
4038

4139
onMouseOver() {
4240
this._isHovering = true;

src/cdk-experimental/testing/tests/test-sub-component.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ import {ChangeDetectionStrategy, Component, Input, ViewEncapsulation} from '@ang
2020
changeDetection: ChangeDetectionStrategy.OnPush,
2121
})
2222
export class TestSubComponent {
23-
// TODO: remove '!'.
24-
@Input() title!: string;
25-
// TODO: remove '!'.
26-
@Input() items!: string[];
23+
@Input() title: string;
24+
@Input() items: string[];
2725
}

0 commit comments

Comments
 (0)