Skip to content

Commit b476e25

Browse files
committed
build: enable type checking of host bindings
Updates to the latest version of the framework and enables type checking of host bindings. Also fixes one regression after a recent refactor.
1 parent 3aecb35 commit b476e25

File tree

9 files changed

+1747
-906
lines changed

9 files changed

+1747
-906
lines changed

.aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Input hashes for repository rule npm_translate_lock(name = "npm2", pnpm_lock = "@//:pnpm-lock.yaml").
33
# This file should be checked into version control along with the pnpm-lock.yaml file.
44
.npmrc=-2023857461
5-
package.json=-1258556846
6-
pnpm-lock.yaml=1977822002
5+
package.json=1644151301
6+
pnpm-lock.yaml=2107069472
77
pnpm-workspace.yaml=1711114604
8-
yarn.lock=1826236985
8+
yarn.lock=1593491870

goldens/material/checkbox/index.api.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ export class MatCheckbox implements AfterViewInit, OnChanges, ControlValueAccess
3535
indeterminateToChecked: string;
3636
indeterminateToUnchecked: string;
3737
};
38+
// (undocumented)
39+
protected _animationsDisabled: boolean;
3840
ariaControls: string;
3941
ariaDescribedby: string;
4042
ariaExpanded: boolean;

package.json

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,12 @@
5656
},
5757
"version": "20.0.0-next.3",
5858
"dependencies": {
59-
"@angular/animations": "^20.0.0-next.0",
60-
"@angular/common": "^20.0.0-next.0",
61-
"@angular/compiler": "^20.0.0-next.0",
62-
"@angular/core": "^20.0.0-next.0",
63-
"@angular/forms": "^20.0.0-next.0",
64-
"@angular/platform-browser": "^20.0.0-next.0",
59+
"@angular/animations": "^20.0.0-next.3",
60+
"@angular/common": "^20.0.0-next.3",
61+
"@angular/compiler": "^20.0.0-next.3",
62+
"@angular/core": "^20.0.0-next.3",
63+
"@angular/forms": "^20.0.0-next.3",
64+
"@angular/platform-browser": "^20.0.0-next.3",
6565
"@types/google.maps": "^3.54.10",
6666
"@types/youtube": "^0.1.0",
6767
"rxjs": "^6.6.7",
@@ -70,19 +70,19 @@
7070
"zone.js": "~0.15.0"
7171
},
7272
"devDependencies": {
73-
"@angular-devkit/build-angular": "^20.0.0-next.0",
74-
"@angular-devkit/core": "^20.0.0-next.0",
75-
"@angular-devkit/schematics": "^20.0.0-next.0",
76-
"@angular/bazel": "https://github.com/angular/bazel-builds.git#ba9ff4622e455b7cad2f983f5e611b9f46c57e86",
77-
"@angular/build": "^20.0.0-next.0",
73+
"@angular-devkit/build-angular": "^20.0.0-next.2",
74+
"@angular-devkit/core": "^20.0.0-next.2",
75+
"@angular-devkit/schematics": "^20.0.0-next.2",
76+
"@angular/bazel": "https://github.com/angular/bazel-builds.git#54a0ac1bc77b58214a1c4d3cdcf167676ea621e4",
77+
"@angular/build": "^20.0.0-next.2",
7878
"@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#ec9df12469082e3cb087a9af55072dc2d833c73f",
79-
"@angular/cli": "^20.0.0-next.0",
80-
"@angular/compiler-cli": "^20.0.0-next.0",
81-
"@angular/localize": "^20.0.0-next.0",
79+
"@angular/cli": "^20.0.0-next.2",
80+
"@angular/compiler-cli": "^20.0.0-next.3",
81+
"@angular/localize": "^20.0.0-next.3",
8282
"@angular/ng-dev": "https://github.com/angular/dev-infra-private-ng-dev-builds.git#1fa3a08b6a111de820da092799319ed47c058849",
83-
"@angular/platform-browser-dynamic": "^20.0.0-next.0",
84-
"@angular/platform-server": "^20.0.0-next.0",
85-
"@angular/router": "^20.0.0-next.0",
83+
"@angular/platform-browser-dynamic": "^20.0.0-next.3",
84+
"@angular/platform-server": "^20.0.0-next.3",
85+
"@angular/router": "^20.0.0-next.3",
8686
"@babel/core": "^7.16.12",
8787
"@babel/helper-explode-assignable-expression": "^7.18.6",
8888
"@babel/helper-string-parser": "^7.22.5",
@@ -102,7 +102,7 @@
102102
"@octokit/rest": "18.3.5",
103103
"@rollup/plugin-commonjs": "^21.0.0",
104104
"@rollup/plugin-node-resolve": "^13.1.3",
105-
"@schematics/angular": "^20.0.0-next.0",
105+
"@schematics/angular": "^20.0.0-next.2",
106106
"@types/babel__core": "^7.1.18",
107107
"@types/browser-sync": "^2.26.3",
108108
"@types/fs-extra": "^9.0.13",

pnpm-lock.yaml

Lines changed: 1048 additions & 647 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/bazel-tsconfig-build.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@
3737
}
3838
},
3939
"angularCompilerOptions": {
40+
"strictTemplates": true,
41+
"typeCheckHostBindings": true,
4042
"extendedDiagnostics": {
4143
"defaultCategory": "error"
4244
}

src/material/checkbox/checkbox.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export class MatCheckbox
115115
_elementRef = inject<ElementRef<HTMLElement>>(ElementRef);
116116
private _changeDetectorRef = inject(ChangeDetectorRef);
117117
private _ngZone = inject(NgZone);
118-
private _animationsDisabled = _animationsDisabled();
118+
protected _animationsDisabled = _animationsDisabled();
119119
private _options = inject<MatCheckboxDefaultOptions>(MAT_CHECKBOX_DEFAULT_OPTIONS, {
120120
optional: true,
121121
});

src/tsconfig-legacy.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
"angularCompilerOptions": {
2929
// This is needed so that test components are not AOT compiled. Ngtsc will
3030
// not find an associated module for test components and error out.
31-
"compileNonExportedClasses": false
31+
"compileNonExportedClasses": false,
32+
"typeCheckHostBindings": true,
33+
"strictTemplates": true
3234
}
3335
}

tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
},
4444
"angularCompilerOptions": {
4545
"strictTemplates": true,
46+
"typeCheckHostBindings": true,
4647
"extendedDiagnostics": {
4748
"defaultCategory": "error"
4849
}

0 commit comments

Comments
 (0)