Merge branch 'master' of github.com:angular/components into giorag/chip-list-focus-last-chip-on-backspace-v2

Author: gioragutt

.bazelrc

@@ -37,16 +37,20 @@ query --output=label_kind
 # By default, failing tests don't print any output, it goes to the log file
 test --test_output=errors
 
-#################################
-# Release configuration.        #
-# Run with "--config=release"   #
-#################################
+####################################
+# Stamping configurations.         #
+# Run with "--config=release" or   #
+# "--config=snapshot-build".       #
+####################################
 
 # Configures script to do version stamping.
 # See https://docs.bazel.build/versions/master/user-manual.html#flag--workspace_status_command
 build:release --workspace_status_command="node ./tools/bazel-stamp-vars.js"
 build:release --stamp
 
+build:snapshot-build --workspace_status_command="node ./tools/bazel-stamp-vars.js --snapshot"
+build:snapshot-build --stamp
+
 ################################
 # View Engine / Ivy toggle     #
 ################################
@@ -77,7 +81,6 @@ build:remote --host_cpu=k8
 # Setup the remote build execution servers.
 build:remote --remote_cache=remotebuildexecution.googleapis.com
 build:remote --remote_executor=remotebuildexecution.googleapis.com
-build:remote --tls_enabled=true
 build:remote --auth_enabled=true
 
 # Setup the toolchain and platform for the remote build execution. The platform
@@ -92,10 +95,18 @@ build:remote --host_platform=//tools:rbe_platform
 build:remote --platforms=//tools:rbe_platform
 build:remote --extra_toolchains=@rbe_default//config:cc-toolchain
 
-# Setup Build Event Service
-build:remote --bes_backend=buildeventservice.googleapis.com
-build:remote --bes_timeout=30s
-build:remote --bes_results_url="https://source.cloud.google.com/results/invocations/"
+################################
+# --config=build-results       #
+################################
+
+# Sets up Build Event Service if the `builds-results` configuration is used. We
+# do not upload build results by default as this makes us reliant on external servers
+# that could cause builds to fail unnecessarily. If desired, build result uploading
+# can be manually uploaded, but given that the build event service server has been
+# less stable than the remote executors, we do not want to degrade CI stability.
+build:build-results --bes_backend=buildeventservice.googleapis.com
+build:build-results --bes_timeout=60s
+build:build-results --bes_results_url="https://source.cloud.google.com/results/invocations/"
 
 # Set remote caching settings
 build:remote --remote_accept_cached=true

.bazelversion

@@ -1 +1 @@
-3.1.0
+4.0.0

.circleci/config.yml

@@ -26,14 +26,6 @@ var_5: &job_defaults
   docker:
     - image: *docker_image
 
-# Job step for checking out the source code from GitHub. This also ensures that the source code
-# is rebased on top of master.
-var_6: &checkout_code
-  checkout:
-    # After checkout, rebase on top of master. By default, PRs are not rebased on top of master,
-    # which we want. See https://discuss.circleci.com/t/1662
-    post: git pull --ff-only origin "refs/pull/${CI_PULL_REQUEST//*pull\//}/merge"
-
 # Restores the cache that could be available for the current Yarn lock file. The cache usually
 # includes the node modules and the Bazel repository cache.
 var_7: &restore_cache
@@ -143,19 +135,50 @@ var_21: &slack_notify_on_failure
   run:
     name: "Notifying team about job failure"
     when: on_fail
-    command: ./scripts/circleci/notify-slack-job-failure.sh
+    command: node ./scripts/circleci/notify-slack-job-failure.js
 
 # -----------------------------
 # Container version of CircleCI
 # -----------------------------
 version: 2.1
 
+# Configures CircleCI orbs for this pipeline. Orbs allow consumption of publicly shared
+# CircleCI commands, jobs, configuration elements or executors. Read more about orbs here:
+# https://circleci.com/docs/2.0/orb-intro/
+orbs:
+  # Set up the `queue` orb that allows us to queue up builds across jobs. We use it
+  # to make sure that snapshot builds are not deployed out of order, resulting in Git
+  # push conflicts.
+  queue: eddiewebb/queue@1.5.0
+
+
+commands:
+  checkout_and_rebase:
+    description: Checkout and rebase the repository
+    steps:
+      - checkout
+      - run:
+          name: Set up environment
+          environment:
+              CIRCLE_GIT_BASE_REVISION: << pipeline.git.base_revision >>
+              CIRCLE_GIT_REVISION: << pipeline.git.revision >>
+          command: ./.circleci/env.sh
+      - run:
+          name: Rebase PR on target branch
+          # After checkout, rebase on top of target branch.
+          command: |
+            if [ -n "$CIRCLE_PR_NUMBER" ]; then
+              # User is required for rebase.
+              git config user.name "angular-ci"
+              git config user.email "angular-ci"
+              node .circleci/rebase-pr.js
+            fi
+
 # -----------------------------------------------------------------------------------------
 # Job definitions. Jobs which are defined just here, will not run automatically. Each job
 # must be part of a workflow definition in order to run for PRs and push builds.
 # -----------------------------------------------------------------------------------------
 jobs:
-
   # -----------------------------------
   # Job to test that everything builds with Bazel
   # -----------------------------------
@@ -165,7 +188,7 @@ jobs:
     environment:
       GCP_DECRYPT_TOKEN: *gcp_decrypt_token
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *setup_bazel_ci_config
       - *setup_bazel_remote_execution
@@ -187,7 +210,7 @@ jobs:
     environment:
       GCP_DECRYPT_TOKEN: *gcp_decrypt_token
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *setup_bazel_ci_config
       - *setup_bazel_remote_execution
@@ -209,7 +232,7 @@ jobs:
     environment:
       GCP_DECRYPT_TOKEN: *gcp_decrypt_token
     steps:
-    - *checkout_code
+    - checkout_and_rebase
     - *restore_cache
     - *setup_bazel_ci_config
     - *setup_bazel_remote_execution
@@ -228,14 +251,17 @@ jobs:
     environment:
       GCP_DECRYPT_TOKEN: *gcp_decrypt_token
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *setup_bazel_ci_config
       - *setup_bazel_remote_execution
       - *yarn_install
       - *setup_bazel_binary
 
-      - run: bazel test src/... --build_tag_filters=e2e --test_tag_filters=e2e --build_tests_only
+      # Run e2e tests. Note that protractor test targets are flaky sometimes, so we run them
+      # with flaky test attempts. This means that Bazel will re-run a failed e2e test target
+      # a second time to ensure it's a real test failure. This improves CI stability.
+      - run: yarn e2e --flaky_test_attempts=2
       - *slack_notify_on_failure
 
   # ------------------------------------------------------------------------------------------
@@ -248,7 +274,7 @@ jobs:
     environment:
       GCP_DECRYPT_TOKEN: *gcp_decrypt_token
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *setup_bazel_ci_config
       - *setup_bazel_remote_execution
@@ -269,7 +295,7 @@ jobs:
       BROWSER_STACK_USERNAME: "angularteam1"
       BROWSER_STACK_ACCESS_KEY: "CaXMeMHD9pr5PHg8N7Jq"
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *setup_bazel_ci_config
       - *yarn_install
@@ -291,7 +317,7 @@ jobs:
       # a rate limit exception.
       KARMA_PARALLEL_BROWSERS: 2
     steps:
-    - *checkout_code
+    - checkout_and_rebase
     - *restore_cache
     - *setup_bazel_ci_config
     - *yarn_install
@@ -304,8 +330,11 @@ jobs:
   # ----------------------------------
   lint:
     <<: *job_defaults
+    environment:
+      CI_GIT_BASE_REVISION: << pipeline.git.base_revision >>
+      CI_GIT_REVISION: << pipeline.git.revision >>
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *setup_bazel_ci_config
       - *yarn_install
@@ -324,10 +353,20 @@ jobs:
             yarn check-entry-point-setup $(bazel info bazel-bin)/entry_points_manifest.json
 
       - run: yarn ng-dev format changed --check << pipeline.git.base_revision >>
+      - run:
+          name: Check Commit Message (PR Only)
+          # Only run the commit message checks on pull requests since we can't do
+          # much about any failures that have made it into the main branch.
+          command: |
+            if [ -n "$CIRCLE_PR_NUMBER" ]; then
+              yarn ng-dev commit-message validate-range --range $CI_COMMIT_RANGE
+            fi
       - run: yarn ownerslint
+      - run: yarn check-mdc-tests
       - run: yarn stylelint
       - run: yarn tslint
       - run: yarn -s ts-circular-deps:check
+      - run: yarn check-mdc-exports
 
       - *slack_notify_on_failure
       - *save_cache
@@ -342,15 +381,23 @@ jobs:
     environment:
       GCP_DECRYPT_TOKEN: *gcp_decrypt_token
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *setup_bazel_ci_config
       - *setup_bazel_remote_execution
       - *yarn_install
       - *setup_bazel_binary
 
       - run: yarn build
-      - run: yarn check-release-output
+      - run:
+          name: Checking release output
+          command: |
+            pkg_json_version=$(node -pe "require('./package.json').version")
+            expected_version="${pkg_json_version}-sha-$(git rev-parse --short HEAD)"
+            yarn check-release-output ${expected_version}
+      - run:
+          name: Checking tooling scripts
+          command: yarn check-tools
 
       # TODO(devversion): replace this with bazel tests that run Madge. This is
       # cumbersome and doesn't guarantee no circular deps for other entry-points.
@@ -389,7 +436,7 @@ jobs:
   upload_release_packages:
     <<: *job_defaults
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *attach_release_output
       - *yarn_install
@@ -410,7 +457,7 @@ jobs:
     environment:
       GCP_DECRYPT_TOKEN: *gcp_decrypt_token
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *attach_release_output
       - *setup_bazel_ci_config
@@ -426,7 +473,18 @@ jobs:
       # The components examples package is not a release package, but we publish it
       # as part of this job to the docs-content repository. It's not contained in the
       # attached release output, so we need to build it here.
-      - run: bazel build src/components-examples:npm_package --config=release
+      - run: yarn build-docs-content
+
+      # Ensures that we do not push the snapshot artifacts upstream until all previous
+      # snapshot build jobs have completed. This helps avoiding conflicts when multiple
+      # commits have been pushed (resulting in multiple concurrent snapshot publish jobs).
+      # We increase the confidence threshold so that it queries the CircleCI API a second time
+      # after a delay. We do this as the CircleCI API does not refresh immediately when a job
+      # completes/starts, and this will improve stability of the queue step. See source:
+      # https://github.com/eddiewebb/circleci-queue/commit/5d42add5bbcff5e8ac7fe189448a61fea98b0839.
+      - queue/until_front_of_line:
+          confidence: "2"
+
       - run: ./scripts/circleci/publish-snapshots.sh
       - *slack_notify_on_failure
 
@@ -437,7 +495,7 @@ jobs:
     <<: *job_defaults
     resource_class: xlarge
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *attach_release_output
       - *yarn_install
@@ -461,7 +519,7 @@ jobs:
     <<: *job_defaults
     resource_class: xlarge
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *attach_release_output
       - *setup_snapshot_builds
@@ -488,7 +546,7 @@ jobs:
     environment:
       GCP_DECRYPT_TOKEN: *gcp_decrypt_token
     steps:
-    - *checkout_code
+    - checkout_and_rebase
     - *restore_cache
     - *setup_bazel_ci_config
     - *setup_bazel_remote_execution
@@ -509,7 +567,7 @@ jobs:
     environment:
       GCP_DECRYPT_TOKEN: *gcp_decrypt_token
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *setup_bazel_ci_config
       - *setup_bazel_remote_execution
@@ -529,7 +587,7 @@ jobs:
     environment:
       GCP_DECRYPT_TOKEN: *gcp_decrypt_token
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *setup_bazel_ci_config
       - *setup_bazel_remote_execution
@@ -550,13 +608,20 @@ jobs:
     environment:
       GCP_DECRYPT_TOKEN: *gcp_decrypt_token
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *setup_bazel_ci_config
       - *setup_bazel_remote_execution
       - *yarn_install
       - *setup_bazel_binary
-      - run: yarn integration-tests
+      # TODO: Re-enable when there are integration tests that should run with Ivy.
+      # Currently this command fails as there are no tests.
+      # - run: yarn integration-tests
+      - run:
+          name: Running size integration tests (failures are reported in Slack only).
+          command: |
+            # If the size integration tests fail, report the failure to a dedicated #components-ci-size-tracking Slack channel.
+            yarn integration-tests:size-test || node ./scripts/circleci/notify-slack-job-failure.js components-ci-size-tracking
       - run: yarn integration-tests:view-engine
       - *slack_notify_on_failure
 
@@ -569,7 +634,7 @@ jobs:
     environment:
       GCP_DECRYPT_TOKEN: *gcp_decrypt_token
     steps:
-      - *checkout_code
+      - checkout_and_rebase
       - *restore_cache
       - *setup_bazel_binary
       - *setup_bazel_ci_config