fix(cdk/overlay): add @Injectable to ConnectedOverlayPositionChange

* fix(cdk/overlay): add @Injectable to ConnectedOverlayPositionChange

Since itls using an Optional decorator in constructor parameter, class ConnectedOverlayPositionChange needs to be decorated itself.

build: noUndecoratedClassWithAngularFeaturesRule tslint rule does detect decorated constructor parameters

Author: trik

src/cdk/overlay/position/connected-position.ts

@@ -7,7 +7,7 @@
  */
 
 /** Horizontal dimension of a connection point on the perimeter of the origin or overlay element. */
-import {Optional} from '@angular/core';
+import {Injectable, Optional} from '@angular/core';
 export type HorizontalConnectionPos = 'start' | 'center' | 'end';
 
 /** Vertical dimension of a connection point on the perimeter of the origin or overlay element. */
@@ -86,6 +86,7 @@ export class ScrollingVisibility {
   isOverlayOutsideView: boolean;
 }
 
+@Injectable()
 /** The change event emitted by the strategy when a fallback position is used. */
 export class ConnectedOverlayPositionChange {
   constructor(

tools/public_api_guard/cdk/overlay.md

@@ -142,13 +142,17 @@ export class CloseScrollStrategy implements ScrollStrategy {
 
 export { ComponentType }
 
-// @public
+// @public (undocumented)
 export class ConnectedOverlayPositionChange {
     constructor(
     connectionPair: ConnectionPositionPair,
     scrollableViewProperties: ScrollingVisibility);
     connectionPair: ConnectionPositionPair;
     scrollableViewProperties: ScrollingVisibility;
+    // (undocumented)
+    static ɵfac: i0.ɵɵFactoryDeclaration<ConnectedOverlayPositionChange, [null, { optional: true; }]>;
+    // (undocumented)
+    static ɵprov: i0.ɵɵInjectableDeclaration<ConnectedOverlayPositionChange>;
 }
 
 // @public
@@ -249,7 +253,7 @@ export class GlobalPositionStrategy implements PositionStrategy {
     width(value?: string): this;
 }
 
-// @public
+// @public (undocumented)
 export type HorizontalConnectionPos = 'start' | 'center' | 'end';
 
 // @public

tools/tslint-rules/noUndecoratedClassWithAngularFeaturesRule.ts

@@ -47,7 +47,15 @@ class Walker extends Lint.RuleWalker {
 
   /** Checks if the specified node has an Angular decorator. */
   private _hasAngularDecorator(node: ts.Node): boolean {
-    return !!node.decorators && node.decorators.some(d => {
+    let decorators = node.decorators || [];
+    if (ts.isConstructorDeclaration(node)) {
+      node.parameters.forEach(param => {
+        if (param.decorators) {
+          decorators = [...decorators, ...param.decorators];
+        }
+      });
+    }
+    return decorators.some(d => {
       if (!ts.isCallExpression(d.expression) || !ts.isIdentifier(d.expression.expression)) {
         return false;
       }