Skip to content

Commit 98572bd

Browse files
devversionandrewseguin
authored andcommitted
build: re-enable browserstack safari tests
BrowserStack team supposedly fixed the upstream issues. We can re-enable the browserstack tests. It was unclear how long it will take the BS team to fix the server issues, so we temporarily disabled the job before. This reverts commit 555037a. (cherry picked from commit 6329ce7)
1 parent 74f26db commit 98572bd

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

.circleci/config.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -525,10 +525,8 @@ workflows:
525525
filters: *ignore_presubmit_branch_filter
526526
- tests_local_browsers:
527527
filters: *ignore_presubmit_branch_filter
528-
# TODO(devversion): temporarily disabled until BrowserStack fixes an issue
529-
# where Safari browsers cannot be launched due to a missing `device'.
530-
#- tests_browserstack:
531-
# filters: *ignore_presubmit_branch_filter
528+
- tests_browserstack:
529+
filters: *ignore_presubmit_branch_filter
532530
- tests_saucelabs:
533531
filters: *ignore_presubmit_branch_filter
534532
- e2e_tests:

.github/angular-robot.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,7 @@ merge:
6060
- "ci/circleci: lint"
6161
- "ci/circleci: bazel_build"
6262
- "ci/circleci: tests_local_browsers"
63-
# TODO(devversion): temporarily disabled until Browserstack tests are re-enabled.
64-
# - "ci/circleci: tests_browserstack"
63+
- "ci/circleci: tests_browserstack"
6564
- "ci/circleci: tests_saucelabs"
6665
- "ci/circleci: build_release_packages"
6766

0 commit comments

Comments
 (0)