Skip to content

Commit 85316f1

Browse files
committed
fix ts lint
1 parent 4acc832 commit 85316f1

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

tools/gulp/tasks/screenshots.ts

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ import {readdirSync, statSync, existsSync, mkdirp, readFileSync, writeFileSync}
33
import * as path from 'path';
44
import * as admin from 'firebase-admin';
55
import * as firebase from 'firebase';
6-
import {openScreenshotsBucket, openFirebaseScreenshotsDatabase, connectFirebaseScreenshots} from '../util/firebase';
6+
import {
7+
openScreenshotsBucket,
8+
openFirebaseScreenshotsDatabase,
9+
connectFirebaseScreenshots} from '../util/firebase';
710
import {setGithubStatus} from '../util/github';
811

912
const imageDiff = require('image-diff');
@@ -47,7 +50,8 @@ function updateResult(database: firebase.database.Database, prNumber: string, re
4750
return getPullRequestRef(database, prNumber).child('result').set(result).then(() => result);
4851
}
4952

50-
function getPullRequestRef(database: firebase.database.Database | admin.database.Database, prNumber: string) {
53+
function getPullRequestRef(database: firebase.database.Database | admin.database.Database,
54+
prNumber: string) {
5155
return database.ref(FIREBASE_REPORT).child(prNumber).child(getSecureToken());
5256
}
5357

@@ -65,13 +69,16 @@ function getScreenshotFiles(database: firebase.database.Database) {
6569
mkdirp(path.join(SCREENSHOT_DIR, `golds`));
6670
mkdirp(path.join(SCREENSHOT_DIR, `diff`));
6771

68-
return database.ref('screenshot/goldens').once('value').then((snapshot: firebase.database.DataSnapshot) => {
72+
return database.ref('screenshot/goldens').once('value')
73+
.then((snapshot: firebase.database.DataSnapshot) => {
6974
let counter = 0;
7075
snapshot.forEach((childSnapshot: firebase.database.DataSnapshot) => {
7176
let key = childSnapshot.key;
7277
let binaryData = new Buffer(childSnapshot.val(), 'base64').toString('binary');
7378
writeFileSync(`${SCREENSHOT_DIR}/golds/${key}.screenshot.png`, binaryData, 'binary');
74-
if (++counter == snapshot.numChildren()) return true;
79+
if (++counter == snapshot.numChildren()) {
80+
return true;
81+
}
7582
});
7683
}).catch((error: any) => console.log(error));
7784
}
@@ -101,7 +108,8 @@ function getSecureToken() {
101108
* If the images are the test results, mode should be 'test'.
102109
* If the images are the diff images generated, mode should be 'diff'.
103110
*/
104-
function uploadScreenshotsData(database: firebase.database.Database, mode: 'test' | 'diff', prNumber: string) {
111+
function uploadScreenshotsData(database: firebase.database.Database,
112+
mode: 'test' | 'diff', prNumber: string) {
105113
let localDir = mode == 'diff' ? path.join(SCREENSHOT_DIR, 'diff') : SCREENSHOT_DIR;
106114
let promises: any[] = [];
107115
getLocalScreenshotFiles(localDir).forEach((file: string) => {
@@ -192,4 +200,4 @@ function uploadScreenshots() {
192200
promises.push(bucket.upload(fileName, { destination: destination }));
193201
});
194202
return Promise.all(promises);
195-
}
203+
}

0 commit comments

Comments
 (0)