Skip to content

Commit 792f0d5

Browse files
committed
update owners and uses of gulp/bazel
1 parent dae84fe commit 792f0d5

File tree

5 files changed

+13
-42
lines changed

5 files changed

+13
-42
lines changed

.circleci/config.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ jobs:
131131
- *setup_bazel_remote_execution
132132

133133
- run: bazel build src/... --build_tag_filters=-docs-package
134-
- run: bazel test src/... --build_tag_filters=-docs-package
134+
- run: bazel test src/... --build_tag_filters=-docs-package --test_tag_filters=-e2e
135135

136136
# Note: We want to save the cache in this job because the workspace cache also
137137
# includes the Bazel repository cache that will be updated in this job.
@@ -168,7 +168,7 @@ jobs:
168168
- *copy_bazel_config
169169
- *setup_bazel_remote_execution
170170

171-
- run: bazel test e2e/...
171+
- run: bazel test src/... --test_tag_filters=e2e
172172

173173
# ------------------------------------------------------------------------------------------
174174
# Job that runs the unit tests on locally installed browsers (Chrome and Firefox headless).
@@ -376,7 +376,7 @@ jobs:
376376
- run: sed -i "s/\(_ENABLE_NG_TYPE_CHECKING = \)True/\1False/g" tools/defaults.bzl
377377
# Run project tests with ngtsc and the Ivy Angular packages.
378378
- run: bazel build src/... --build_tag_filters=-docs-package --define=compile=aot
379-
- run: bazel test src/... --build_tag_filters=-docs-package --define=compile=aot
379+
- run: bazel test src/... --build_tag_filters=-docs-package --define=compile=aot --test_tag_filters=-e2e
380380

381381
# ----------------------------------------------------------------------------
382382
# Job that runs all Bazel tests against Ivy from angular/angular#master.
@@ -401,7 +401,7 @@ jobs:
401401
- run: sed -i "s/\(_ENABLE_NG_TYPE_CHECKING = \)True/\1False/g" tools/defaults.bzl
402402
# Run project tests with ngtsc and the Ivy Angular packages.
403403
- run: bazel build src/... --build_tag_filters=-docs-package --define=compile=aot
404-
- run: bazel test src/... --build_tag_filters=-docs-package --define=compile=aot
404+
- run: bazel test src/... --build_tag_filters=-docs-package --define=compile=aot --test_tag_filters=-e2e
405405

406406
# ----------------------------------------------------------------------------------------
407407
# Workflow definitions. A workflow usually groups multiple jobs together. This is useful if

.github/CODEOWNERS

Lines changed: 1 addition & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -171,38 +171,6 @@
171171
/src/dev-app/virtual-scroll/** @mmalerba
172172

173173
# E2E app
174-
/e2e/* @jelbourn
175-
/e2e/components/block-scroll-strategy-e2e.spec.ts @andrewseguin @crisbeto
176-
/e2e/components/button-e2e.spec.ts @jelbourn
177-
/e2e/components/button-toggle-e2e.spec.ts @jelbourn
178-
/e2e/components/card-e2e.spec.ts @jelbourn
179-
/e2e/components/checkbox-e2e.spec.ts @jelbourn @devversion
180-
/e2e/components/dialog-e2e.spec.ts @jelbourn @crisbeto
181-
/e2e/components/expansion-e2e.spec.ts @josephperrott @jelbourn
182-
/e2e/components/grid-list-e2e.spec.ts @jelbourn
183-
/e2e/components/icon-e2e.spec.ts @jelbourn
184-
/e2e/components/input-e2e.spec.ts @mmalerba
185-
/e2e/components/list-e2e.spec.ts @jelbourn @crisbeto @devversion
186-
/e2e/components/mdc-button-e2e.spec.ts @andrewseguin
187-
# Note to implementer: please repossess
188-
/e2e/components/mdc-card-e2e.spec.ts @mmalerba
189-
/e2e/components/mdc-checkbox-e2e.spec.ts @mmalerba
190-
/e2e/components/mdc-chips-e2e.spec.ts @mmalerba
191-
/e2e/components/mdc-menu-e2e.spec.ts @crisbeto
192-
# Note to implementer: please repossess
193-
/e2e/components/mdc-radio-e2e.spec.ts @mmalerba
194-
/e2e/components/mdc-slide-toggle-e2e.spec.ts @crisbeto
195-
/e2e/components/menu-e2e.spec.ts @crisbeto
196-
/e2e/components/progress-bar-e2e.spec.ts @jelbourn @crisbeto @josephperrott
197-
/e2e/components/progress-spinner-e2e.spec.ts @jelbourn @crisbeto @josephperrott
198-
/e2e/components/radio-e2e.spec.ts @jelbourn @devversion
199-
/e2e/components/sidenav-e2e.spec.ts @mmalerba
200-
/e2e/components/slide-toggle-e2e.spec.ts @devversion
201-
/e2e/components/stepper-e2e.spec.ts @mmalerba
202-
/e2e/components/tabs-e2e.spec.ts @andrewseguin
203-
/e2e/components/toolbar-e2e.spec.ts @devversion
204-
/e2e/components/virtual-scroll-e2e.spec.ts @mmalerba
205-
/e2e/util/** @jelbourn
206174
/src/e2e-app/* @jelbourn
207175
/src/e2e-app/block-scroll-strategy/** @andrewseguin @crisbeto
208176
/src/e2e-app/button/** @jelbourn
@@ -234,6 +202,7 @@
234202
/src/e2e-app/slide-toggle/** @devversion
235203
/src/e2e-app/stepper/** @mmalerba
236204
/src/e2e-app/tabs/** @andrewseguin
205+
/src/e2e-app/test-util/** @jelbourn
237206
/src/e2e-app/toolbar/** @devversion
238207
/src/e2e-app/virtual-scroll/** @mmalerba
239208

DEV_ENVIRONMENT.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313
To build Material in dev mode, run `gulp material:build`.
1414
To build Material in release mode, run `gulp material:build-release`
1515

16-
To bring up a local server, run `gulp serve:devapp`. This will automatically watch for changes
16+
To bring up a local server, run `yarn dev-app`. This will automatically watch for changes
1717
and rebuild. The browser should refresh automatically when changes are made.
1818

1919
### Running tests
2020

21-
To run unit tests, run `gulp test`.
22-
To run the e2e tests, run `gulp e2e`.
23-
To run lint, run `gulp lint`.
21+
To run unit tests, run `yarn test`.
22+
To run the e2e tests, run `yarn e2e`.
23+
To run lint, run `yarn lint`.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
"postinstall": "ngc -p angular-tsconfig.json",
1616
"build": "gulp build-release-packages",
1717
"dev-app": "gulp serve:devapp",
18-
"test": "bazel test //src/...",
18+
"test": "bazel test //src/... --test_tag_filters=-e2e",
1919
"lint": "gulp lint",
20-
"e2e": "bazel test //e2e/...",
20+
"e2e": "bazel test //src/... --test_tag_filters=e2e",
2121
"deploy": "gulp deploy:devapp",
2222
"webdriver-manager": "webdriver-manager",
2323
"breaking-changes": "gulp breaking-changes",

tools/package-tools/rollup-globals.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ const rollupCdkExperimentalEntryPoints =
4848
export const rollupGlobals = {
4949
'moment': 'moment',
5050
'tslib': 'tslib',
51+
'protractor': 'protractor',
52+
'selenium-webdriver': 'selenium-webdriver',
5153

5254
// MDC Web
5355
'@material/animation': 'mdc.animation',

0 commit comments

Comments
 (0)