Address feedback

Author: devversion

.circleci/config.yml

@@ -141,10 +141,10 @@ jobs:
       - run: ./scripts/circleci/run-browserstack-tests.sh
 
   # -----------------------------------------------------------------------------------------
-  # Job that builds the demo-app with AOT. In order to speed up this job, the release output
+  # Job that builds the dev-app with AOT. In order to speed up this job, the release output
   # from the workspace storage will be attached to this job.
   # -----------------------------------------------------------------------------------------
-  build_demoapp_aot:
+  build_devapp_aot:
     <<: *job_defaults
     steps:
       - *checkout_code
@@ -181,7 +181,7 @@ jobs:
 
   # -------------------------------------------------------------------------------------------
   # Job that builds all release packages with Gulp. The built packages can be then used in the
-  # same workflow to publish snapshot builds or test the demo-app with the release packages.
+  # same workflow to publish snapshot builds or test the dev-app with the release packages.
   # -------------------------------------------------------------------------------------------
   build_release_packages:
     <<: *job_defaults
@@ -277,7 +277,7 @@ workflows:
   release_output:
     jobs:
       - build_release_packages
-      - build_demoapp_aot:
+      - build_devapp_aot:
           requires:
             - build_release_packages
       - publish_snapshots:

.github/CODEOWNERS

@@ -94,58 +94,59 @@
 /guides/**                                         @jelbourn
 /src/material-examples/**                          @jelbourn
 
-# Demo app
-/src/demo-app/*                                    @jelbourn
-/src/demo-app/a11y-demos/**                        @jelbourn
-/src/demo-app/library-demos/*                      @jelbourn
-/src/demo-app/library-demos/autocomplete/**        @crisbeto
-/src/demo-app/library-demos/badge/**               @jelbourn
-/src/demo-app/library-demos/baseline/**            @mmalerba
-/src/demo-app/library-demos/bottom-sheet/**        @jelbourn @crisbeto
-/src/demo-app/library-demos/button-toggle/**       @jelbourn
-/src/demo-app/library-demos/button/**              @jelbourn
-/src/demo-app/library-demos/card/**                @jelbourn
-/src/demo-app/library-demos/checkbox/**            @jelbourn @devversion
-/src/demo-app/library-demos/chips/**               @jelbourn
-/src/demo-app/library-demos/connected-overlay/**   @jelbourn @crisbeto
-/src/demo-app/library-demos/dataset/**             @andrewseguin
-/src/demo-app/library-demos/datepicker/**          @mmalerba
-/src/demo-app/library-demos/dialog/**              @jelbourn @crisbeto
-/src/demo-app/library-demos/drawer/**              @mmalerba
-/src/demo-app/library-demos/drag-drop/**           @crisbeto
-/src/demo-app/library-demos/example/**             @andrewseguin
-/src/demo-app/library-demos/examples-page/**       @andrewseguin
-/src/demo-app/library-demos/expansion/**           @josephperrott
-/src/demo-app/library-demos/focus-origin/**        @mmalerba
-/src/demo-app/library-demos/gestures/**            @jelbourn
-/src/demo-app/library-demos/grid-list/**           @jelbourn
-/src/demo-app/library-demos/icon/**                @jelbourn
-/src/demo-app/library-demos/input/**               @mmalerba
-/src/demo-app/library-demos/list/**                @jelbourn @crisbeto @devversion
-/src/demo-app/library-demos/menu/**                @crisbeto
-/src/demo-app/library-demos/live-announcer/**      @jelbourn
-/src/demo-app/library-demos/overlay/**             @jelbourn @crisbeto
-/src/demo-app/library-demos/paginator/**           @andrewseguin
-/src/demo-app/library-demos/platform/**            @jelbourn @devversion
-/src/demo-app/library-demos/portal/**              @jelbourn
-/src/demo-app/library-demos/progress-bar/**        @jelbourn @crisbeto @josephperrott
-/src/demo-app/library-demos/progress-spinner/**    @jelbourn @crisbeto @josephperrott
-/src/demo-app/library-demos/radio/**               @jelbourn @devversion
-/src/demo-app/library-demos/ripple/**              @devversion
-/src/demo-app/library-demos/screen-type/**         @josephperrott
-/src/demo-app/library-demos/select/**              @crisbeto
-/src/demo-app/library-demos/sidenav/**             @mmalerba
-/src/demo-app/library-demos/slide-toggle/**        @devversion
-/src/demo-app/library-demos/slider/**              @mmalerba
-/src/demo-app/library-demos/snack-bar/**           @jelbourn @crisbeto @josephperrott
-/src/demo-app/library-demos/stepper/**             @mmalerba
-/src/demo-app/library-demos/table/**               @andrewseguin
-/src/demo-app/library-demos/tabs/**                @andrewseguin
-/src/demo-app/library-demos/toolbar/**             @devversion
-/src/demo-app/library-demos/tooltip/**             @andrewseguin
-/src/demo-app/library-demos/tree/**                @jelbourn
-/src/demo-app/library-demos/typography/**          @crisbeto
-/src/demo-app/library-demos/virtual-scroll/**      @mmalerba
+# Accessibility demos
+/src/a11y-demo/**/*                                @jelbourn
+
+# Dev-app
+/src/dev-app/*                                     @jelbourn
+/src/dev-app/autocomplete/**                       @crisbeto
+/src/dev-app/badge/**                              @jelbourn
+/src/dev-app/baseline/**                           @mmalerba
+/src/dev-app/bottom-sheet/**                       @jelbourn @crisbeto
+/src/dev-app/button-toggle/**                      @jelbourn
+/src/dev-app/button/**                             @jelbourn
+/src/dev-app/card/**                               @jelbourn
+/src/dev-app/checkbox/**                           @jelbourn @devversion
+/src/dev-app/chips/**                              @jelbourn
+/src/dev-app/connected-overlay/**                  @jelbourn @crisbeto
+/src/dev-app/dataset/**                            @andrewseguin
+/src/dev-app/datepicker/**                         @mmalerba
+/src/dev-app/dialog/**                             @jelbourn @crisbeto
+/src/dev-app/drawer/**                             @mmalerba
+/src/dev-app/drag-drop/**                          @crisbeto
+/src/dev-app/example/**                            @andrewseguin
+/src/dev-app/examples-page/**                      @andrewseguin
+/src/dev-app/expansion/**                          @josephperrott
+/src/dev-app/focus-origin/**                       @mmalerba
+/src/dev-app/gestures/**                           @jelbourn
+/src/dev-app/grid-list/**                          @jelbourn
+/src/dev-app/icon/**                               @jelbourn
+/src/dev-app/input/**                              @mmalerba
+/src/dev-app/list/**                               @jelbourn @crisbeto @devversion
+/src/dev-app/menu/**                               @crisbeto
+/src/dev-app/live-announcer/**                     @jelbourn
+/src/dev-app/overlay/**                            @jelbourn @crisbeto
+/src/dev-app/paginator/**                          @andrewseguin
+/src/dev-app/platform/**                           @jelbourn @devversion
+/src/dev-app/portal/**                             @jelbourn
+/src/dev-app/progress-bar/**                       @jelbourn @crisbeto @josephperrott
+/src/dev-app/progress-spinner/**                   @jelbourn @crisbeto @josephperrott
+/src/dev-app/radio/**                              @jelbourn @devversion
+/src/dev-app/ripple/**                             @devversion
+/src/dev-app/screen-type/**                        @josephperrott
+/src/dev-app/select/**                             @crisbeto
+/src/dev-app/sidenav/**                            @mmalerba
+/src/dev-app/slide-toggle/**                       @devversion
+/src/dev-app/slider/**                             @mmalerba
+/src/dev-app/snack-bar/**                          @jelbourn @crisbeto @josephperrott
+/src/dev-app/stepper/**                            @mmalerba
+/src/dev-app/table/**                              @andrewseguin
+/src/dev-app/tabs/**                               @andrewseguin
+/src/dev-app/toolbar/**                            @devversion
+/src/dev-app/tooltip/**                            @andrewseguin
+/src/dev-app/tree/**                               @jelbourn
+/src/dev-app/typography/**                         @crisbeto
+/src/dev-app/virtual-scroll/**                     @mmalerba
 
 # E2E app
 /e2e/*                                             @jelbourn

CODE_REVIEWS.md

@@ -1,6 +1,6 @@
 {
   "hosting": {
-    "public": "dist/packages/demo-app",
+    "public": "dist/packages/dev-app",
     "rewrites": [
       {
         "source": "/**/!(*.@(js|ts|html|css|json|svg|png|jpg|jpeg))",

firebase.json

@@ -13,7 +13,7 @@
   },
   "scripts": {
     "build": "gulp :publish:build-releases",
-    "demo-app": "gulp serve:devapp",
+    "dev-app": "gulp serve:devapp",
     "test": "gulp test",
     "tslint": "gulp lint",
     "stylelint": "gulp lint",

package.json

@@ -0,0 +1,19 @@
+package(default_visibility=["//visibility:public"])
+
+load("//:packages.bzl", "MATERIAL_TARGETS")
+load("//tools:defaults.bzl", "ng_module")
+load("//tools:sass_generate_binaries.bzl", "sass_generate_binaries")
+
+# Generate sass binaries for all nested SCSS files.
+sass_generate_binaries("a11y_demo_scss", glob(["**/*.scss"]))
+
+ng_module(
+  name = "a11y-demo",
+  srcs = glob(["**/*.ts"], exclude=["**/*.spec.ts"]),
+  assets = glob(["**/*.html"]) + [":a11y_demo_scss"],
+  deps = [
+    "@angular//packages/core",
+    "@angular//packages/router",
+    "//src/cdk/table",
+  ] + MATERIAL_TARGETS
+)

src/a11y-demo/BUILD.bazel

@@ -10,9 +10,9 @@ import {CommonModule} from '@angular/common';
 import {NgModule} from '@angular/core';
 import {FormsModule, ReactiveFormsModule} from '@angular/forms';
 import {RouterModule} from '@angular/router';
-import {DemoMaterialModule} from '../demo-material-module';
 import {AccessibilityDemoHome, AccessibilityDemoRoot} from './a11y-demo';
 import {ACCESSIBILITY_DEMO_ROUTES} from './a11y-demo-routes';
+import {DemoMaterialModule} from './a11y-material-module';
 import {AutocompleteAccessibilityDemo} from './autocomplete/autocomplete-a11y';
 import {ButtonToggleAccessibilityDemo} from './button-toggle/button-toggle-a11y';
 import {ButtonAccessibilityDemo} from './button/button-a11y';

src/demo-app/a11y-demos/a11y-demo-module.ts renamed to src/a11y-demo/a11y-demo-module.ts

@@ -17,7 +17,6 @@ import {Subscription} from 'rxjs';
 })
 export class AccessibilityDemoRoot implements OnDestroy {
   currentComponent = '';
-
   fullscreen = false;
 
   private _routerSubscription = Subscription.EMPTY;
@@ -85,6 +84,6 @@ export class AccessibilityDemoRoot implements OnDestroy {
 @Component({
   moduleId: module.id,
   selector: 'accessibility-home',
-  template: `<p>Welcome to the accessibility demos for Angular Material!</p>`,
+  template: `<p>Welcome to the accessibility examples for Angular Material!</p>`,
 })
 export class AccessibilityDemoHome {}

src/demo-app/a11y-demos/a11y-demo-routes.ts renamed to src/a11y-demo/a11y-demo-routes.ts

@@ -0,0 +1,77 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
+import {CdkTableModule} from '@angular/cdk/table';
+import {NgModule} from '@angular/core';
+import {
+  MatAutocompleteModule,
+  MatButtonModule,
+  MatButtonToggleModule,
+  MatCardModule,
+  MatCheckboxModule,
+  MatChipsModule,
+  MatDatepickerModule,
+  MatDialogModule,
+  MatExpansionModule,
+  MatGridListModule,
+  MatIconModule,
+  MatInputModule,
+  MatListModule,
+  MatMenuModule,
+  MatPaginatorModule,
+  MatProgressBarModule,
+  MatProgressSpinnerModule,
+  MatRadioModule,
+  MatSelectModule,
+  MatSidenavModule,
+  MatSliderModule,
+  MatSlideToggleModule,
+  MatSnackBarModule,
+  MatTableModule,
+  MatTabsModule,
+  MatToolbarModule,
+  MatTooltipModule,
+} from '@angular/material';
+
+/**
+ * NgModule that includes all Material modules that are required to serve the dev-app.
+ */
+@NgModule({
+  exports: [
+    CdkTableModule,
+    MatAutocompleteModule,
+    MatButtonModule,
+    MatButtonToggleModule,
+    MatCardModule,
+    MatCheckboxModule,
+    MatChipsModule,
+    MatTableModule,
+    MatDatepickerModule,
+    MatDialogModule,
+    MatExpansionModule,
+    MatGridListModule,
+    MatIconModule,
+    MatInputModule,
+    MatListModule,
+    MatMenuModule,
+    MatPaginatorModule,
+    MatProgressBarModule,
+    MatProgressSpinnerModule,
+    MatRadioModule,
+    MatSelectModule,
+    MatSidenavModule,
+    MatSliderModule,
+    MatSlideToggleModule,
+    MatSnackBarModule,
+    MatTableModule,
+    MatTabsModule,
+    MatToolbarModule,
+    MatTooltipModule,
+  ]
+})
+export class DemoMaterialModule {}