Skip to content

Commit 706ba7e

Browse files
committed
fixup! fix(material/form-field): allow getting harness by validity
1 parent 3475e30 commit 706ba7e

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

src/material/form-field/testing/form-field-harness-filters.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ export interface FormFieldHarnessFilters extends BaseHarnessFilters {
1515
/** Filters based on whether the form field has error messages. */
1616
hasErrors?: boolean;
1717
/** Filters based on whether the form field value is valid. */
18-
valid?: boolean;
18+
isValid?: boolean;
1919
}

src/material/form-field/testing/form-field-harness.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ export class MatFormFieldHarness extends _MatFormFieldHarnessBase<
251251
)
252252
.addOption(
253253
'valid',
254-
options.valid,
254+
options.isValid,
255255
async (harness, valid) => (await harness.isControlValid()) === valid,
256256
);
257257
}

src/material/form-field/testing/shared.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,13 +198,13 @@ export function runHarnessTests(
198198
});
199199

200200
it('should be able to get form-field by validity', async () => {
201-
let invalid = await loader.getAllHarnesses(formFieldHarness.with({valid: false}));
201+
let invalid = await loader.getAllHarnesses(formFieldHarness.with({isValid: false}));
202202
expect(invalid.length).toBe(0);
203203

204204
fixture.componentInstance.requiredControl.setValue('');
205205
dispatchFakeEvent(fixture.nativeElement.querySelector('#with-errors input'), 'blur');
206206

207-
invalid = await loader.getAllHarnesses(formFieldHarness.with({valid: false}));
207+
invalid = await loader.getAllHarnesses(formFieldHarness.with({isValid: false}));
208208
expect(invalid.length).toBe(1);
209209
});
210210

src/material/legacy-form-field/testing/form-field-harness.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export class MatLegacyFormFieldHarness extends _MatFormFieldHarnessBase<
6060
)
6161
.addOption(
6262
'valid',
63-
options.valid,
63+
options.isValid,
6464
async (harness, valid) => (await harness.isControlValid()) === valid,
6565
);
6666
}

tools/public_api_guard/material/form-field-testing.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ export type FormFieldControlHarness = MatInputHarness | MatSelectHarness | MatDa
2828
export interface FormFieldHarnessFilters extends BaseHarnessFilters {
2929
floatingLabelText?: string | RegExp;
3030
hasErrors?: boolean;
31+
isValid?: boolean;
3132
}
3233

3334
// @public

0 commit comments

Comments
 (0)