Address review comments #2

Author: Yifan Ge

src/cdk-experimental/selection/row-selection.ts

@@ -21,21 +21,17 @@ import {CdkSelection} from './selection';
 @Directive({
   selector: '[cdkRowSelection]',
   host: {
-    '[class.cdk-selected]': '_selection.isSelected(this._value, this._index)',
-    '[attr.aria-selected]': '_selection.isSelected(this._value, this._index)',
+    '[class.cdk-selected]': '_selection.isSelected(this.value, this.index)',
+    '[attr.aria-selected]': '_selection.isSelected(this.value, this.index)',
   },
 })
 export class CdkRowSelection<T> {
-  @Input('cdkRowSelectionValue') _value: T;
+  @Input('cdkRowSelectionValue') value: T;
 
   @Input('cdkRowSelectionIndex')
-  get index(): number|undefined {
-    return this._index;
-  }
-  set index(index: number|undefined) {
-    this._index = coerceNumberProperty(index);
-  }
-  _index?: number;
+  get index(): number|undefined { return this._index; }
+  set index(index: number|undefined) { this._index = coerceNumberProperty(index); }
+  private _index?: number;
 
   constructor(readonly _selection: CdkSelection<T>) {}
 

src/cdk-experimental/selection/select-all.ts

@@ -8,7 +8,7 @@
 
 import {Directive, Inject, isDevMode, OnDestroy, OnInit, Optional, Self} from '@angular/core';
 import {ControlValueAccessor, NG_VALUE_ACCESSOR} from '@angular/forms';
-import {Observable, of as observableOf, ReplaySubject} from 'rxjs';
+import {Observable, of as observableOf, Subject} from 'rxjs';
 import {switchMap, takeUntil} from 'rxjs/operators';
 
 import {CdkSelection} from './selection';
@@ -48,7 +48,7 @@ export class CdkSelectAll<T> implements OnDestroy, OnInit {
   /**
    * Toggles the select-all state.
    * @param event The click event if the toggle is triggered by a (mouse or keyboard) click. If
-   *     using with a native <input type="checkbox">, the parameter is required for the
+   *     using with a native `<input type="checkbox">`, the parameter is required for the
    *     indeterminate state to work properly.
    */
   toggle(event?: MouseEvent) {
@@ -64,7 +64,7 @@ export class CdkSelectAll<T> implements OnDestroy, OnInit {
     });
   }
 
-  private readonly _destroyed = new ReplaySubject(1);
+  private readonly _destroyed = new Subject<void>();
 
   constructor(
       @Optional() private readonly _selection: CdkSelection<T>,

src/cdk-experimental/selection/selection-column.ts

@@ -60,7 +60,7 @@ export class CdkSelectionColumn<T> implements OnInit, OnDestroy {
 
     this.syncColumnDefName();
   }
-  _name: string;
+  private _name: string;
 
   @ViewChild(CdkColumnDef, {static: true}) private readonly _columnDef: CdkColumnDef;
   @ViewChild(CdkCellDef, {static: true}) private readonly _cell: CdkCellDef;

src/cdk-experimental/selection/selection-toggle.ts

@@ -18,8 +18,8 @@ import {
   Self
 } from '@angular/core';
 import {ControlValueAccessor, NG_VALUE_ACCESSOR} from '@angular/forms';
-import {BehaviorSubject, Observable, of as observableOf, ReplaySubject, Subject} from 'rxjs';
-import {distinctUntilChanged, startWith, switchMap, takeUntil} from 'rxjs/operators';
+import {Observable, of as observableOf, Subject} from 'rxjs';
+import {distinctUntilChanged, switchMap, takeUntil} from 'rxjs/operators';
 
 import {CdkSelection} from './selection';
 
@@ -39,16 +39,12 @@ import {CdkSelection} from './selection';
 })
 export class CdkSelectionToggle<T> implements OnDestroy, OnInit {
   /** The value that is associated with the toggle */
-  @Input('cdkSelectionToggleValue') private _value: T;
+  @Input('cdkSelectionToggleValue') value: T;
 
   /** The index of the value in the list. Required when used with `trackBy` */
   @Input('cdkSelectionToggleIndex')
-  get index(): number|undefined {
-    return this._index;
-  }
-  set index(index: number|undefined) {
-    this._index = coerceNumberProperty(index);
-  }
+  get index(): number|undefined { return this._index; }
+  set index(index: number|undefined) { this._index = coerceNumberProperty(index); }
   private _index?: number;
 
   /** The checked state of the selection toggle */
@@ -59,10 +55,10 @@ export class CdkSelectionToggle<T> implements OnDestroy, OnInit {
 
   /** Toggles the selection */
   toggle() {
-    this._selection.toggleSelection(this._value, this._index);
+    this._selection.toggleSelection(this.value, this.index);
   }
 
-  private _destroyed = new ReplaySubject(1);
+  private _destroyed = new Subject<void>();
 
   constructor(
       @Optional() private _selection: CdkSelection<T>,
@@ -101,7 +97,7 @@ export class CdkSelectionToggle<T> implements OnDestroy, OnInit {
   }
 
   private _isSelected(): boolean {
-    return this._selection.isSelected(this._value, this._index);
+    return this._selection.isSelected(this.value, this.index);
   }
 
   static ngAcceptInputType_index: NumberInput;

src/cdk-experimental/selection/selection.ts

@@ -19,7 +19,7 @@ import {
   Output,
   TrackByFunction
 } from '@angular/core';
-import {Observable, of as observableOf, ReplaySubject, Subscription} from 'rxjs';
+import {Observable, of as observableOf, Subject, Subscription} from 'rxjs';
 import {takeUntil} from 'rxjs/operators';
 
 import {SelectableWithIndex, SelectionChange, SelectionSet} from './selection-set';
@@ -48,7 +48,7 @@ export class CdkSelection<T> implements OnInit, AfterContentChecked, CollectionV
   }
   private _dataSource: TableDataSource<T>;
 
-  @Input('trackBy') private _trackByFn: TrackByFunction<T>;
+  @Input('trackBy') trackByFn: TrackByFunction<T>;
 
   /** Whether to support multiple selection */
   @Input('cdkSelectionMultiple')
@@ -69,7 +69,7 @@ export class CdkSelection<T> implements OnInit, AfterContentChecked, CollectionV
   /** Subscription that listens for the data provided by the data source.  */
   private _renderChangeSubscription: Subscription|null;
 
-  private _destroyed = new ReplaySubject<void>(1);
+  private _destroyed = new Subject<void>();
 
   private _selection: SelectionSet<T>;
 
@@ -115,7 +115,7 @@ export class CdkSelection<T> implements OnInit, AfterContentChecked, CollectionV
   }
 
   ngOnInit() {
-    this._selection = new SelectionSet<T>(this._multiple, this._trackByFn);
+    this._selection = new SelectionSet<T>(this._multiple, this.trackByFn);
     this._selection.changed.pipe(takeUntil(this._destroyed)).subscribe((change) => {
       this.updateSelectAllState();
       this.change.emit(change);
@@ -139,7 +139,7 @@ export class CdkSelection<T> implements OnInit, AfterContentChecked, CollectionV
 
   /** Toggles selection for a given value. `index` is required if `trackBy` is used. */
   toggleSelection(value: T, index?: number) {
-    if (this._trackByFn && index == null && isDevMode()) {
+    if (this.trackByFn && index == null && isDevMode()) {
       throw Error('CdkSelection: index required when trackBy is used');
     }
 
@@ -168,7 +168,7 @@ export class CdkSelection<T> implements OnInit, AfterContentChecked, CollectionV
 
   /** Checks whether a value is selected. `index` is required if `trackBy` is used. */
   isSelected(value: T, index?: number) {
-    if (this._trackByFn && index == null && isDevMode()) {
+    if (this.trackByFn && index == null && isDevMode()) {
       throw Error('CdkSelection: index required when trackBy is used');
     }