Skip to content

Commit 5d41978

Browse files
authored
build: remove ts-node forking bug workaround (#26756)
In the past, `ts-node` had a bug that prevented forking processes when used in combination with `--esm`. We contributed a fix upstream to `ts-node` to fix this, and this commit updates to the latest version so that we can simplify our `ng-dev` invocation. TypeStrong/ts-node@32d07e2
1 parent ef0fa05 commit 5d41978

File tree

2 files changed

+6
-16
lines changed

2 files changed

+6
-16
lines changed

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
},
1616
"scripts": {
1717
"postinstall": "node tools/postinstall/apply-patches.js",
18-
"ng-dev": "cross-env TS_NODE_PROJECT=$PWD/.ng-dev/tsconfig.json TS_NODE_TRANSPILE_ONLY=1 node --no-warnings --loader ts-node/esm node_modules/@angular/ng-dev/bundles/cli.mjs",
18+
"ng-dev": "ts-node --esm --project .ng-dev/tsconfig.json --transpile-only node_modules/@angular/ng-dev/bundles/cli.mjs",
1919
"ng-dev:stamp": "yarn -s ng-dev release build-env-stamp --additional-stamping-script=tools/bazel-additional-stamp.mjs",
2020
"build": "ts-node --esm --project scripts/tsconfig.json ./scripts/build-packages-dist-main.mts",
2121
"build-docs-content": "ts-node --esm --project scripts/tsconfig.json ./scripts/build-docs-content-main.mts",
@@ -166,7 +166,6 @@
166166
"browser-sync": "2.26.13",
167167
"chalk": "^4.1.0",
168168
"codelyzer": "^6.0.2",
169-
"cross-env": "^7.0.3",
170169
"date-fns": "^2.28.0",
171170
"dgeni": "^0.4.14",
172171
"dgeni-packages": "^0.29.5",
@@ -211,7 +210,7 @@
211210
"shelljs": "^0.8.5",
212211
"stylelint": "^14.14.0",
213212
"terser": "^5.10.0",
214-
"ts-node": "^10.8.1",
213+
"ts-node": "^10.9.1",
215214
"tsec": "0.2.2",
216215
"tsickle": "0.39.1",
217216
"tslint": "^6.1.3",

yarn.lock

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@
150150

151151
"@angular/build-tooling@https://github.com/angular/dev-infra-private-build-tooling-builds.git#16f13b9e919478d61ec98ce60901f3bdebb5d4e5":
152152
version "0.0.0-93e50fe950f04508be0ea7adfc1b7f8efd459adc"
153-
uid "16f13b9e919478d61ec98ce60901f3bdebb5d4e5"
154153
resolved "https://github.com/angular/dev-infra-private-build-tooling-builds.git#16f13b9e919478d61ec98ce60901f3bdebb5d4e5"
155154
dependencies:
156155
"@angular-devkit/build-angular" "16.0.0-next.1"
@@ -282,7 +281,6 @@
282281

283282
"@angular/ng-dev@https://github.com/angular/dev-infra-private-ng-dev-builds.git#46a6cb28a6ca6a3a7a096656280ed27b02243e9a":
284283
version "0.0.0-93e50fe950f04508be0ea7adfc1b7f8efd459adc"
285-
uid "46a6cb28a6ca6a3a7a096656280ed27b02243e9a"
286284
resolved "https://github.com/angular/dev-infra-private-ng-dev-builds.git#46a6cb28a6ca6a3a7a096656280ed27b02243e9a"
287285
dependencies:
288286
"@yarnpkg/lockfile" "^1.1.0"
@@ -6464,13 +6462,6 @@ cross-env@^5.1.3:
64646462
dependencies:
64656463
cross-spawn "^6.0.5"
64666464

6467-
cross-env@^7.0.3:
6468-
version "7.0.3"
6469-
resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-7.0.3.tgz#865264b29677dc015ba8418918965dd232fc54cf"
6470-
integrity sha512-+/HKd6EgcQCJGh2PSjZuUitQBQynKor4wrFbRg4DtAgS1aWO+gU52xpH7M9ScGgXSYmAVS9bIJ8EzuaGw0oNAw==
6471-
dependencies:
6472-
cross-spawn "^7.0.1"
6473-
64746465
cross-spawn@^5.0.1:
64756466
version "5.1.0"
64766467
resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-5.1.0.tgz#e8bd0efee58fcff6f8f94510a0a554bbfa235449"
@@ -15060,10 +15051,10 @@ trough@^1.0.0:
1506015051
resolved "https://registry.yarnpkg.com/true-case-path/-/true-case-path-2.2.1.tgz#c5bf04a5bbec3fd118be4084461b3a27c4d796bf"
1506115052
integrity sha512-0z3j8R7MCjy10kc/g+qg7Ln3alJTodw9aDuVWZa3uiWqfuBMKeAeP2ocWcxoyM3D73yz3Jt/Pu4qPr4wHSdB/Q==
1506215053

15063-
ts-node@^10.8.1:
15064-
version "10.8.1"
15065-
resolved "https://registry.yarnpkg.com/ts-node/-/ts-node-10.8.1.tgz#ea2bd3459011b52699d7e88daa55a45a1af4f066"
15066-
integrity sha512-Wwsnao4DQoJsN034wePSg5nZiw4YKXf56mPIAeD6wVmiv+RytNSWqc2f3fKvcUoV+Yn2+yocD71VOfQHbmVX4g==
15054+
ts-node@^10.9.1:
15055+
version "10.9.1"
15056+
resolved "https://registry.yarnpkg.com/ts-node/-/ts-node-10.9.1.tgz#e73de9102958af9e1f0b168a6ff320e25adcff4b"
15057+
integrity sha512-NtVysVPkxxrwFGUUxGYhfux8k78pQB3JqYBXlLRZgdGUqTO5wU/UyHop5p70iEbGhB7q5KmiZiU0Y3KlJrScEw==
1506715058
dependencies:
1506815059
"@cspotcode/source-map-support" "^0.8.0"
1506915060
"@tsconfig/node10" "^1.0.7"

0 commit comments

Comments
 (0)