Skip to content

Commit 58118ec

Browse files
authored
build: run commit message check after other lint checks (#22208)
We recently had some lint failures slip into the main branch, because they had both commit message failures and other lint failures. The problem was that we sometimes ignore commit message failures since they can be fixed by the caretaker, but if the commit check fails, it prevents any other the other lint checks from running. These changes move the commit message check to be last in the `lint` job so that if it fails, we know that everything else is in a mergeable state.
1 parent b2622b4 commit 58118ec

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

.circleci/config.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -353,6 +353,13 @@ jobs:
353353
yarn check-entry-point-setup $(bazel info bazel-bin)/entry_points_manifest.json
354354
355355
- run: yarn ng-dev format changed --check << pipeline.git.base_revision >>
356+
- run: yarn ownerslint
357+
- run: yarn check-mdc-tests
358+
- run: yarn stylelint
359+
- run: yarn tslint
360+
- run: yarn -s ts-circular-deps:check
361+
- run: yarn check-mdc-exports
362+
# Should be last so that it doesn't prevent the other lint checks from running.
356363
- run:
357364
name: Check Commit Message (PR Only)
358365
# Only run the commit message checks on pull requests since we can't do
@@ -361,12 +368,6 @@ jobs:
361368
if [ -n "$CIRCLE_PR_NUMBER" ]; then
362369
yarn ng-dev commit-message validate-range --range $CI_COMMIT_RANGE
363370
fi
364-
- run: yarn ownerslint
365-
- run: yarn check-mdc-tests
366-
- run: yarn stylelint
367-
- run: yarn tslint
368-
- run: yarn -s ts-circular-deps:check
369-
- run: yarn check-mdc-exports
370371
371372
- *slack_notify_on_failure
372373
- *save_cache

0 commit comments

Comments
 (0)