Skip to content

Commit 4e211e5

Browse files
committed
fix lint and api check
1 parent c825190 commit 4e211e5

File tree

3 files changed

+16
-7
lines changed

3 files changed

+16
-7
lines changed

src/cdk/testing/tests/protractor.e2e.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ import {SubComponentHarness, SubComponentSpecialHarness} from './harnesses/sub-c
1212
// Kagekiri is available globally in the browser. We declare it here so we can use it in the
1313
// browser-side script passed to `by.js`.
1414
// TODO(mmalerba): Replace with type-only import once TS 3.8 is available
15-
// https://devblogs.microsoft.com/typescript/announcing-typescript-3-8-beta/#type-only-imports-exports
15+
// tslint:disable-next-line:max-line-length
16+
// See: https://devblogs.microsoft.com/typescript/announcing-typescript-3-8-beta/#type-only-imports-exports
1617
declare const kagekiri: {
1718
querySelectorAll: (selector: string, root: Element) => NodeListOf<Element>;
1819
};

tools/public_api_guard/cdk/testing/protractor.d.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,16 @@ export declare class ProtractorElement implements TestElement {
1919
}
2020

2121
export declare class ProtractorHarnessEnvironment extends HarnessEnvironment<ElementFinder> {
22-
protected constructor(rawRootElement: ElementFinder, _queryFn?: (selector: string, root: ElementFinder) => ElementArrayFinder);
22+
protected constructor(rawRootElement: ElementFinder, options?: ProtractorHarnessEnvironmentOptions);
2323
protected createEnvironment(element: ElementFinder): HarnessEnvironment<ElementFinder>;
2424
protected createTestElement(element: ElementFinder): TestElement;
2525
forceStabilize(): Promise<void>;
2626
protected getAllRawElements(selector: string): Promise<ElementFinder[]>;
2727
protected getDocumentRoot(): ElementFinder;
2828
waitForTasksOutsideAngular(): Promise<void>;
29-
static loader(queryFn?: (selector: string, root: ElementFinder) => ElementArrayFinder): HarnessLoader;
29+
static loader(options?: ProtractorHarnessEnvironmentOptions): HarnessLoader;
30+
}
31+
32+
export interface ProtractorHarnessEnvironmentOptions {
33+
queryFn: (selector: string, root: ElementFinder) => ElementArrayFinder;
3034
}

tools/public_api_guard/cdk/testing/testbed.d.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,18 @@
11
export declare class TestbedHarnessEnvironment extends HarnessEnvironment<Element> {
2-
protected constructor(rawRootElement: Element, _fixture: ComponentFixture<unknown>, _queryFn?: (selector: string, root: Element) => ArrayLike<Element>);
2+
protected constructor(rawRootElement: Element, _fixture: ComponentFixture<unknown>, options?: TestbedHarnessEnvironmentOptions);
33
protected createEnvironment(element: Element): HarnessEnvironment<Element>;
44
protected createTestElement(element: Element): TestElement;
55
forceStabilize(): Promise<void>;
66
protected getAllRawElements(selector: string): Promise<Element[]>;
77
protected getDocumentRoot(): Element;
88
waitForTasksOutsideAngular(): Promise<void>;
9-
static documentRootLoader(fixture: ComponentFixture<unknown>, queryFn?: (selector: string, root: Element) => ArrayLike<Element>): HarnessLoader;
10-
static harnessForFixture<T extends ComponentHarness>(fixture: ComponentFixture<unknown>, harnessType: ComponentHarnessConstructor<T>, queryFn?: (selector: string, root: Element) => ArrayLike<Element>): Promise<T>;
11-
static loader(fixture: ComponentFixture<unknown>, queryFn?: (selector: string, root: Element) => ArrayLike<Element>): HarnessLoader;
9+
static documentRootLoader(fixture: ComponentFixture<unknown>, options?: TestbedHarnessEnvironmentOptions): HarnessLoader;
10+
static harnessForFixture<T extends ComponentHarness>(fixture: ComponentFixture<unknown>, harnessType: ComponentHarnessConstructor<T>, options?: TestbedHarnessEnvironmentOptions): Promise<T>;
11+
static loader(fixture: ComponentFixture<unknown>, options?: TestbedHarnessEnvironmentOptions): HarnessLoader;
12+
}
13+
14+
export interface TestbedHarnessEnvironmentOptions {
15+
queryFn: (selector: string, root: Element) => ArrayLike<Element>;
1216
}
1317

1418
export declare class UnitTestElement implements TestElement {

0 commit comments

Comments
 (0)