Skip to content

Commit 44487ec

Browse files
committed
build: fix incorrect packaging of theme-color schematic
The `rules_js` `npm_package` rule does not support nested NPM packages, so we should stop doing that and instead use an idiomatic filegroup.
1 parent 1c89c49 commit 44487ec

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

src/material/schematics/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ npm_package(
100100
":ng_generate_assets",
101101
":schema_assets",
102102
":schematics_rjs",
103-
"//src/material/schematics/ng-generate/theme-color:npm_package",
103+
"//src/material/schematics/ng-generate/theme-color:npm_package_assets",
104104
"//src/material/schematics/ng-update:ng_update_index",
105105
],
106106
)

src/material/schematics/ng-generate/theme-color/BUILD.bazel

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin")
2-
load("//tools:defaults.bzl", "esbuild", "pkg_npm")
2+
load("//tools:defaults.bzl", "esbuild")
33
load("//tools:defaults2.bzl", "jasmine_test", "ts_project")
44

55
package(default_visibility = ["//visibility:public"])
@@ -48,10 +48,9 @@ esbuild(
4848
],
4949
)
5050

51-
pkg_npm(
52-
name = "npm_package",
53-
srcs = STATIC_ASSETS,
54-
deps = [":index_bundled"],
51+
filegroup(
52+
name = "npm_package_assets",
53+
srcs = STATIC_ASSETS + [":index_bundled"],
5554
)
5655

5756
########################################

0 commit comments

Comments
 (0)