Skip to content

Commit 3810387

Browse files
committed
added comment about 650ms
1 parent 7ff00e4 commit 3810387

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/lib/core/style/focus-classes.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {Component, Renderer, ViewChild} from '@angular/core';
33
import {StyleModule} from './index';
44
import {By} from '@angular/platform-browser';
55
import {TAB} from '../keyboard/keycodes';
6-
import {FocusOriginMonitor, FocusOrigin, CdkFocusClasses} from './focus-classes';
6+
import {FocusOriginMonitor, FocusOrigin, CdkFocusClasses, TOUCH_BUFFER_MS} from './focus-classes';
77

88
describe('FocusOriginMonitor', () => {
99
let fixture: ComponentFixture<PlainButton>;
@@ -106,7 +106,7 @@ describe('FocusOriginMonitor', () => {
106106
expect(buttonElement.classList.contains('cdk-touch-focused'))
107107
.toBe(true, 'button should have cdk-touch-focused class');
108108
expect(changeHandler).toHaveBeenCalledWith('touch');
109-
}, 650);
109+
}, TOUCH_BUFFER_MS);
110110
}));
111111

112112
it('should detect programmatic focus', async(() => {
@@ -303,7 +303,7 @@ describe('cdkFocusClasses', () => {
303303
expect(buttonElement.classList.contains('cdk-touch-focused'))
304304
.toBe(true, 'button should have cdk-touch-focused class');
305305
expect(changeHandler).toHaveBeenCalledWith('touch');
306-
}, 650);
306+
}, TOUCH_BUFFER_MS);
307307
}));
308308

309309
it('should detect programmatic focus', async(() => {

src/lib/core/style/focus-classes.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@ import {Observable} from 'rxjs/Observable';
33
import {Subject} from 'rxjs/Subject';
44

55

6-
const TOUCH_BUFFER_MS = 650;
6+
// This is the value used by AngularJS Material. Through trial and error (on iPhone 6S) they found
7+
// that a value of around 650ms seems appropriate.
8+
export const TOUCH_BUFFER_MS = 650;
79

810

911
export type FocusOrigin = 'touch' | 'mouse' | 'keyboard' | 'program';

0 commit comments

Comments
 (0)