Skip to content

Commit 30f540b

Browse files
committed
fix(material-experimental/mdc-slider): code review changes
* use #waitForAsync instead of #fixture.whenStable
1 parent 21dc362 commit 30f540b

File tree

1 file changed

+7
-19
lines changed

1 file changed

+7
-19
lines changed

src/material-experimental/mdc-slider/slider.spec.ts

Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import {dispatchMouseEvent, dispatchPointerEvent} from '@angular/cdk/testing/private';
1010
import {Component, DebugElement, Type} from '@angular/core';
11-
import {ComponentFixture, TestBed} from '@angular/core/testing';
11+
import {ComponentFixture, TestBed, waitForAsync} from '@angular/core/testing';
1212
import {RippleRef, RippleState} from '@angular/material/core';
1313
import {By} from '@angular/platform-browser';
1414
import {Thumb} from '@material/slider';
@@ -35,17 +35,13 @@ describe('MDC-based MatSlider' , () => {
3535
let sliderInstance: MatSlider;
3636
let inputInstance: MatSliderThumb;
3737

38-
beforeEach(() => {
38+
beforeEach(waitForAsync(() => {
3939
fixture = createComponent(StandardSlider);
4040
fixture.detectChanges();
4141
sliderDebugElement = fixture.debugElement.query(By.directive(MatSlider));
4242
sliderInstance = sliderDebugElement.componentInstance;
4343
inputInstance = sliderInstance._getInput(Thumb.END);
44-
});
45-
46-
beforeEach(done => {
47-
fixture.whenStable().then(() => done());
48-
});
44+
}));
4945

5046
it('should set the default values', () => {
5147
expect(inputInstance.value).toBe(0);
@@ -87,18 +83,14 @@ describe('MDC-based MatSlider' , () => {
8783
let startInputInstance: MatSliderThumb;
8884
let endInputInstance: MatSliderThumb;
8985

90-
beforeEach(() => {
86+
beforeEach(waitForAsync(() => {
9187
fixture = createComponent(StandardRangeSlider);
9288
fixture.detectChanges();
9389
sliderDebugElement = fixture.debugElement.query(By.directive(MatSlider));
9490
sliderInstance = sliderDebugElement.componentInstance;
9591
startInputInstance = sliderInstance._getInput(Thumb.START);
9692
endInputInstance = sliderInstance._getInput(Thumb.END);
97-
});
98-
99-
beforeEach(done => {
100-
fixture.whenStable().then(() => done());
101-
});
93+
}));
10294

10395
it('should set the default values', () => {
10496
expect(startInputInstance.value).toBe(0);
@@ -160,19 +152,15 @@ describe('MDC-based MatSlider' , () => {
160152
let thumbX: number;
161153
let thumbY: number;
162154

163-
beforeEach(() => {
155+
beforeEach(waitForAsync(() => {
164156
fixture = createComponent(StandardSlider);
165157
fixture.detectChanges();
166158
const sliderDebugElement = fixture.debugElement.query(By.directive(MatSlider));
167159
const sliderInstance = sliderDebugElement.componentInstance;
168160
inputInstance = sliderInstance._getInput(Thumb.END);
169161
thumbInstance = sliderInstance._getThumb();
170162
thumbElement = thumbInstance._getHostElement();
171-
});
172-
173-
beforeEach(done => {
174-
fixture.whenStable().then(() => done());
175-
});
163+
}));
176164

177165
beforeEach(() => {
178166
const thumbDimensions = thumbElement.getBoundingClientRect();

0 commit comments

Comments
 (0)