Skip to content

Commit 2eab16c

Browse files
devversiontinayuangao
authored andcommitted
build: fix dashboard typescript failures (#8616)
* Fixes TypeScript errors for the dashboard app.
1 parent 3c3aadc commit 2eab16c

File tree

5 files changed

+12
-10
lines changed

5 files changed

+12
-10
lines changed

tools/dashboard/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"@angular/platform-browser": "^5.0.0",
2121
"@angular/platform-browser-dynamic": "^5.0.0",
2222
"@angular/router": "^5.0.0",
23-
"@swimlane/ngx-charts": "^6.0.0",
23+
"@swimlane/ngx-charts": "^7.0.1",
2424
"angularfire2": "^5.0.0-rc.2",
2525
"core-js": "^2.4.1",
2626
"d3": "^4.9.1",
@@ -35,6 +35,6 @@
3535
"@types/jasmine": "2.5.45",
3636
"@types/node": "~6.0.60",
3737
"ts-node": "~3.0.4",
38-
"typescript": "^2.4.1"
38+
"typescript": "~2.4.2"
3939
}
4040
}

tools/dashboard/src/app/coverage-chart/coverage-chart.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
[showXAxisLabel]="true"
1010
[showYAxisLabel]="true"
1111
[showGridLines]="true"
12+
[timeline]="true"
1213
[xAxisLabel]="xAxisLabel"
1314
[yAxisLabel]="yAxisLabel"
1415
[autoScale]="true">

tools/dashboard/src/app/dashboard-app.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ export class DashboardApp {
1717
coverage: Observable<CoverageResult[]>;
1818

1919
constructor(database: AngularFireDatabase) {
20-
this.payloads = database.list(`payloads`).valueChanges();
21-
this.coverage = database.list(`coverage-reports`).valueChanges();
20+
this.payloads = database.list<PayloadResult>('payloads').valueChanges();
21+
this.coverage = database.list<CoverageResult>('coverage-reports').valueChanges();
2222
}
2323
}
2424

tools/dashboard/src/app/dashboard-module.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1+
import {NgModule} from '@angular/core';
2+
import {MatCardModule, MatProgressSpinnerModule, MatToolbarModule} from '@angular/material';
13
import {BrowserModule} from '@angular/platform-browser';
4+
import {BrowserAnimationsModule} from '@angular/platform-browser/animations';
5+
import {NgxChartsModule} from '@swimlane/ngx-charts';
26
import {AngularFireModule} from 'angularfire2';
37
import {AngularFireDatabaseModule} from 'angularfire2/database';
4-
import {NgModule} from '@angular/core';
5-
import {DashboardApp} from './dashboard-app';
68
import {environment} from '../environments/environment';
7-
import {MatCardModule, MatProgressSpinnerModule, MatToolbarModule} from '@angular/material';
8-
import {NgxChartsModule} from '@swimlane/ngx-charts';
9-
import {BrowserAnimationsModule} from '@angular/platform-browser/animations';
10-
import {PayloadChart} from './payload-chart/payload-chart';
119
import {CoverageChart} from './coverage-chart/coverage-chart';
10+
import {DashboardApp} from './dashboard-app';
11+
import {PayloadChart} from './payload-chart/payload-chart';
1212

1313
@NgModule({
1414
exports: [

tools/dashboard/src/app/payload-chart/payload-chart.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
[showXAxisLabel]="true"
1010
[showYAxisLabel]="true"
1111
[showGridLines]="true"
12+
[timeline]="true"
1213
[xAxisLabel]="xAxisLabel"
1314
[yAxisLabel]="yAxisLabel"
1415
[autoScale]="true">

0 commit comments

Comments
 (0)