Skip to content

Commit 29f119e

Browse files
committed
fix(material-experimental/mdc-slider): code review changes
* delete commented out code * add comment explaining why emitChangeEvent and emitInputEvent are ignored
1 parent 390b5f0 commit 29f119e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/material-experimental/mdc-slider/slider-adapter.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ export class SliderAdapter implements MDCSliderAdapter {
6262
}
6363
isRTL = (): boolean => {
6464
// TODO(wagnermaciel): Actually implementing this.
65-
// throw Error('Method not implemented.');
6665
return false;
6766
}
6867
setThumbStyleProperty = (propertyName: string, value: string, thumb: Thumb): void => {
@@ -90,6 +89,8 @@ export class SliderAdapter implements MDCSliderAdapter {
9089
setPointerCapture = (pointerId: number): void => {
9190
this._delegate._hostElement.setPointerCapture(pointerId);
9291
}
92+
// We ignore emitChangeEvent and emitInputEvent because the slider inputs
93+
// are already exposed so users can just listen for those events directly themselves.
9394
emitChangeEvent = (value: number, thumb: Thumb): void => {};
9495
emitInputEvent = (value: number, thumb: Thumb): void => {};
9596
emitDragStartEvent = (value: number, thumb: Thumb): void => {

0 commit comments

Comments
 (0)