Skip to content

Commit 224d7b2

Browse files
devversionzarend
authored andcommitted
build: remove ngcc compatibility CI test jobs
Removes all the ngcc compatibility CI jobs as the APF v13 output no longer comes with View Engine output and makes ngcc a noop for the Angular Component package output.
1 parent 0d1dc02 commit 224d7b2

File tree

1 file changed

+0
-56
lines changed

1 file changed

+0
-56
lines changed

.circleci/config.yml

Lines changed: 0 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -434,54 +434,6 @@ jobs:
434434
- run: ./scripts/circleci/publish-snapshots.sh
435435
- *slack_notify_on_failure
436436

437-
# -----------------------------------------------------------------
438-
# Job that ensures that the release output is compatible with ngcc.
439-
# -----------------------------------------------------------------
440-
ngcc_compatibility:
441-
<<: *job_defaults
442-
resource_class: xlarge
443-
steps:
444-
- checkout_and_rebase
445-
- *restore_cache
446-
- *attach_release_output
447-
- *yarn_install
448-
449-
# Copy the release packages into the node modules so that ngcc can process them.
450-
- run: cp -R dist/releases/* node_modules/@angular/
451-
# Delete existing ngcc manifests that would prevent the copied packages
452-
# from being discovered.
453-
- run: rm -f node_modules/__ngcc_entry_points__.json
454-
# Ensure that the job fails if an entry-point cannot be compiled. Also disable
455-
# tsconfig parsing as that causes the release packages to be incorrectly resolved
456-
# to the sources due to path mapping.
457-
- run: yarn ngcc --error-on-failed-entry-point --no-tsconfig
458-
- *slack_notify_on_failure
459-
460-
# -----------------------------------------------------------------
461-
# Job that ensures that the release output is compatible with the
462-
# latest snapshot ngcc changes.
463-
# -----------------------------------------------------------------
464-
ngcc_compatibility_snapshot:
465-
<<: *job_defaults
466-
resource_class: xlarge
467-
steps:
468-
- checkout_and_rebase
469-
- *restore_cache
470-
- *attach_release_output
471-
- *setup_snapshot_builds
472-
- *yarn_install_loose_lockfile
473-
474-
# Copy the release packages into the node modules so that ngcc can process them.
475-
- run: cp -R dist/releases/* node_modules/@angular/
476-
# Delete existing ngcc manifests that would prevent the copied packages
477-
# from being discovered.
478-
- run: rm -f node_modules/__ngcc_entry_points__.json
479-
# Ensure that the job fails if an entry-point cannot be compiled. Also disable
480-
# tsconfig parsing as that causes the release packages to be incorrectly resolved
481-
# to the sources due to path mapping.
482-
- run: yarn ngcc --error-on-failed-entry-point --no-tsconfig
483-
- *slack_notify_on_failure
484-
485437
# ----------------------------------------------------------------------------
486438
# Job that runs the local browser tests against the Angular Github snapshots
487439
# ----------------------------------------------------------------------------
@@ -611,14 +563,6 @@ workflows:
611563
- build_release_packages
612564
- lint:
613565
filters: *ignore_presubmit_branch_filter
614-
- ngcc_compatibility:
615-
filters: *ignore_presubmit_branch_filter
616-
requires:
617-
- build_release_packages
618-
- ngcc_compatibility_snapshot:
619-
filters: *only_main_branch_filter
620-
requires:
621-
- build_release_packages
622566
- publish_snapshots:
623567
filters: *publish_branches_filter
624568
requires:

0 commit comments

Comments
 (0)