Skip to content

Commit 0b70edd

Browse files
committed
fixup! fix(material/schematics): add handling for several api changes
1 parent d99bb06 commit 0b70edd

File tree

2 files changed

+4
-52
lines changed

2 files changed

+4
-52
lines changed

src/material/schematics/ng-generate/mdc-migration/rules/components/slider/slider-template.spec.ts

Lines changed: 3 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ describe('slider template migrator', () => {
9797
);
9898
await runMigrationTest(
9999
`
100-
<mat-slider tickInterval></mat-slider>`,
100+
<mat-slider tickInterval="2"></mat-slider>`,
101101
`
102102
<!-- TODO: The 'tickInterval' property no longer exists -->
103103
<mat-slider><input matSliderThumb /></mat-slider>`,
@@ -109,62 +109,18 @@ describe('slider template migrator', () => {
109109
<!-- TODO: The 'valueText' property no longer exists -->
110110
<mat-slider><input matSliderThumb /></mat-slider>`,
111111
);
112-
await runMigrationTest(
113-
`
114-
<mat-slider defaultColor></mat-slider>`,
115-
`
116-
<!-- TODO: The 'defaultColor' property no longer exists -->
117-
<mat-slider><input matSliderThumb /></mat-slider>`,
118-
);
119-
await runMigrationTest(
120-
`
121-
<mat-slider defaultTabIndex></mat-slider>`,
122-
`
123-
<!-- TODO: The 'defaultTabIndex' property no longer exists -->
124-
<mat-slider><input matSliderThumb /></mat-slider>`,
125-
);
126-
await runMigrationTest(
127-
`
128-
<mat-slider onTouched></mat-slider>`,
129-
`
130-
<!-- TODO: The 'onTouched' property no longer exists -->
131-
<mat-slider><input matSliderThumb /></mat-slider>`,
132-
);
133112
await runMigrationTest(
134113
`
135114
<mat-slider
136115
vertical
137116
invert
138117
[valueText]="myValueText"
139-
defaultColor="accent"
140-
defaultTabIndex="4"
141-
[onTouched]="touchHandler"></mat-slider>`,
118+
tickInterval="4"></mat-slider>`,
142119
`
143120
<!-- TODO: The 'valueText' property no longer exists -->
144-
<!-- TODO: The 'onTouched' property no longer exists -->
145121
<!-- TODO: The 'vertical' property no longer exists -->
146122
<!-- TODO: The 'invert' property no longer exists -->
147-
<!-- TODO: The 'defaultColor' property no longer exists -->
148-
<!-- TODO: The 'defaultTabIndex' property no longer exists -->
149-
<mat-slider><input matSliderThumb /></mat-slider>`,
150-
);
151-
await runMigrationTest(
152-
`
153-
<button>Click Me</button><mat-slider
154-
vertical
155-
invert
156-
[valueText]="myValueText"
157-
defaultColor="accent"
158-
defaultTabIndex="4"
159-
[onTouched]="touchHandler"></mat-slider>`,
160-
`
161-
<button>Click Me</button>
162-
<!-- TODO: The 'valueText' property no longer exists -->
163-
<!-- TODO: The 'onTouched' property no longer exists -->
164-
<!-- TODO: The 'vertical' property no longer exists -->
165-
<!-- TODO: The 'invert' property no longer exists -->
166-
<!-- TODO: The 'defaultColor' property no longer exists -->
167-
<!-- TODO: The 'defaultTabIndex' property no longer exists -->
123+
<!-- TODO: The 'tickInterval' property no longer exists -->
168124
<mat-slider><input matSliderThumb /></mat-slider>`,
169125
);
170126
});

src/material/schematics/ng-generate/mdc-migration/rules/components/slider/slider-template.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,7 @@ export class SliderTemplateMigrator extends TemplateMigrator {
5656
binding.name === 'invert' ||
5757
binding.name === 'vertical' ||
5858
binding.name === 'tickInterval' ||
59-
binding.name === 'valueText' ||
60-
binding.name === 'defaultColor' ||
61-
binding.name === 'defaultTabIndex' ||
62-
binding.name === 'onTouched'
59+
binding.name === 'valueText'
6360
) {
6461
// Remove the binding and leave a comment.
6562
comments.push(`<!-- TODO: The '${binding.name}' property no longer exists -->`);
@@ -109,7 +106,6 @@ export class SliderTemplateMigrator extends TemplateMigrator {
109106
? comments.join(indentation)
110107
: indentation + comments.join(indentation);
111108

112-
console.log(commentStr);
113109
return {
114110
offset: node.sourceSpan.start.offset,
115111
updateFn: (html: string) =>

0 commit comments

Comments
 (0)