fix(cdk/testing): extract hidden text in web driver element (#23239)

crisbeto · web-flow · commit 0742babf332b · 2021-07-26T10:02:53.000-07:00
In #21540 we added support for extracting text from hidden elements in Protractor, but before the PR could be merged, we introduced the WebDriver environment which didn't include the fix and is failing the e2e tests. These changes port over the fix.
diff --git a/src/cdk/testing/selenium-webdriver/selenium-web-driver-element.ts b/src/cdk/testing/selenium-webdriver/selenium-web-driver-element.ts
@@ -136,7 +136,9 @@ export class SeleniumWebDriverElement implements TestElement {
     if (options?.exclude) {
       return this._executeScript(_getTextWithExcludedElements, this.element(), options.exclude);
     }
-    return this.element().getText();
+    // We don't go through the WebDriver `getText`, because it excludes text from hidden elements.
+    return this._executeScript(
+      (element: Element) => (element.textContent || '').trim(), this.element());
   }
 
   /** Gets the value for the given attribute from the element. */

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,9 @@ export class SeleniumWebDriverElement implements TestElement {`
`136`	`136`	`if (options?.exclude) {`
`137`	`137`	`return this._executeScript(_getTextWithExcludedElements, this.element(), options.exclude);`
`138`	`138`	`}`
`139`		`- return this.element().getText();`
	`139`	+ // We don't go through the WebDriver `getText`, because it excludes text from hidden elements.
	`140`	`+ return this._executeScript(`
	`141`	`+ (element: Element) => (element.textContent \|\| '').trim(), this.element());`
`140`	`142`	`}`
`141`	`143`
`142`	`144`	`/** Gets the value for the given attribute from the element. */`