Skip to content

Commit 0734564

Browse files
authored
feat(cdk/listbox): add listbox to cdk (#25380)
* feat(cdk/listbox): add listbox to cdk * fixup! feat(cdk/listbox): add listbox to cdk
1 parent 72946f6 commit 0734564

File tree

57 files changed

+165
-16
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+165
-16
lines changed

.github/CODEOWNERS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@
8989
/src/cdk/drag-drop/** @crisbeto
9090
/src/cdk/keycodes/** @andrewseguin
9191
/src/cdk/layout/** @andrewseguin
92+
/src/cdk/listbox/** @jelbourn
9293
/src/cdk/menu/** @mmalerba @crisbeto
9394
/src/cdk/observers/** @andrewseguin @crisbeto
9495
/src/cdk/overlay/** @jelbourn @crisbeto
@@ -142,7 +143,6 @@
142143
/src/cdk-experimental/popover-edit/** @andrewseguin
143144
/src/cdk-experimental/scrolling/** @mmalerba
144145
/src/cdk-experimental/table-scroll-container/** @andrewseguin
145-
/src/cdk-experimental/listbox/** @jelbourn
146146
/src/cdk-experimental/selection/** @andrewseguin
147147

148148
# Docs examples & guides
@@ -160,8 +160,8 @@
160160
/src/dev-app/button/** @andrewseguin
161161
/src/dev-app/card/** @andrewseguin
162162
/src/dev-app/cdk-dialog/** @crisbeto
163+
/src/dev-app/cdk-listbox/** @jelbourn
163164
/src/dev-app/cdk-experimental-combobox/** @jelbourn
164-
/src/dev-app/cdk-experimental-listbox/** @jelbourn
165165
/src/dev-app/checkbox/** @jelbourn @devversion
166166
/src/dev-app/chips/** @andrewseguin
167167
/src/dev-app/clipboard/** @andrewseguin

.ng-dev/commit-message.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ export const commitMessage: CommitMessageConfig = {
1111
'multiple', // For when a commit applies to multiple components.
1212
'cdk-experimental/column-resize',
1313
'cdk-experimental/combobox',
14-
'cdk-experimental/listbox',
1514
'cdk-experimental/popover-edit',
1615
'cdk-experimental/scrolling',
1716
'cdk-experimental/selection',
@@ -26,6 +25,7 @@ export const commitMessage: CommitMessageConfig = {
2625
'cdk/drag-drop',
2726
'cdk/keycodes',
2827
'cdk/layout',
28+
'cdk/listbox',
2929
'cdk/menu',
3030
'cdk/observers',
3131
'cdk/overlay',

scripts/approve-api-golden.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,5 @@ const apiGoldenTargetName = `//tools/public_api_guard:${packageName}/${suffix}.m
3232
// ShellJS should exit if any command fails.
3333
shelljs.set('-e');
3434
shelljs.cd(projectDir);
35+
shelljs.touch(path.join(projectDir, `tools/public_api_guard/${packageName}/${suffix}.md`));
3536
shelljs.exec(`yarn bazel run ${apiGoldenTargetName}`);

src/cdk-experimental/config.bzl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
CDK_EXPERIMENTAL_ENTRYPOINTS = [
33
"column-resize",
44
"combobox",
5-
"listbox",
65
"popover-edit",
76
"scrolling",
87
"selection",

src/cdk/config.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ CDK_ENTRYPOINTS = [
1010
"drag-drop",
1111
"keycodes",
1212
"layout",
13+
"listbox",
1314
"menu",
1415
"observers",
1516
"overlay",

src/cdk-experimental/listbox/BUILD.bazel renamed to src/cdk/listbox/BUILD.bazel

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
1+
load("//tools:defaults.bzl", "markdown_to_html", "ng_module", "ng_test_library", "ng_web_test_suite")
22

33
package(default_visibility = ["//visibility:public"])
44

@@ -37,3 +37,13 @@ ng_web_test_suite(
3737
name = "unit_tests",
3838
deps = [":unit_test_sources"],
3939
)
40+
41+
markdown_to_html(
42+
name = "overview",
43+
srcs = [":listbox.md"],
44+
)
45+
46+
filegroup(
47+
name = "source-files",
48+
srcs = glob(["**/*.ts"]),
49+
)
File renamed without changes.

src/cdk-experimental/listbox/listbox.spec.ts renamed to src/cdk/listbox/listbox.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {fakeAsync, TestBed, tick} from '@angular/core/testing';
22
import {Component, Type} from '@angular/core';
33
import {By} from '@angular/platform-browser';
44
import {CdkListbox, CdkListboxModule, CdkOption, ListboxValueChangeEvent} from './index';
5-
import {dispatchKeyboardEvent, dispatchMouseEvent} from '../../cdk/testing/private';
5+
import {dispatchKeyboardEvent, dispatchMouseEvent} from '../testing/private';
66
import {
77
A,
88
B,
File renamed without changes.

src/components-examples/cdk-experimental/listbox/BUILD.bazel renamed to src/components-examples/cdk/listbox/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ ng_module(
1010
"**/*.css",
1111
]),
1212
deps = [
13-
"//src/cdk-experimental/listbox",
13+
"//src/cdk/listbox",
1414
"@npm//@angular/common",
1515
"@npm//@angular/forms",
1616
],

src/components-examples/cdk-experimental/listbox/index.ts renamed to src/components-examples/cdk/listbox/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import {CdkListboxOverviewExample} from './cdk-listbox-overview/cdk-listbox-over
1313
import {CdkListboxReactiveFormsExample} from './cdk-listbox-reactive-forms/cdk-listbox-reactive-forms-example';
1414
import {CdkListboxTemplateFormsExample} from './cdk-listbox-template-forms/cdk-listbox-template-forms-example';
1515
import {CdkListboxValueBindingExample} from './cdk-listbox-value-binding/cdk-listbox-value-binding-example';
16-
import {CdkListboxModule} from '@angular/cdk-experimental/listbox';
16+
import {CdkListboxModule} from '@angular/cdk/listbox';
1717

1818
export {
1919
CdkListboxActivedescendantExample,

src/dev-app/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ ng_module(
2424
"//src/dev-app/card",
2525
"//src/dev-app/cdk-dialog",
2626
"//src/dev-app/cdk-experimental-combobox",
27-
"//src/dev-app/cdk-experimental-listbox",
27+
"//src/dev-app/cdk-listbox",
2828
"//src/dev-app/cdk-menu",
2929
"//src/dev-app/checkbox",
3030
"//src/dev-app/chips",

src/dev-app/cdk-experimental-listbox/BUILD.bazel renamed to src/dev-app/cdk-listbox/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ load("//tools:defaults.bzl", "ng_module")
33
package(default_visibility = ["//visibility:public"])
44

55
ng_module(
6-
name = "cdk-experimental-listbox",
6+
name = "cdk-listbox",
77
srcs = glob(["**/*.ts"]),
88
assets = [
99
"cdk-listbox-demo.html",
1010
],
1111
deps = [
12-
"//src/components-examples/cdk-experimental/listbox",
12+
"//src/components-examples/cdk/listbox",
1313
],
1414
)

src/dev-app/cdk-experimental-listbox/cdk-listbox-demo.ts renamed to src/dev-app/cdk-listbox/cdk-listbox-demo.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88

99
import {ChangeDetectionStrategy, Component} from '@angular/core';
10-
import {CdkListboxExamplesModule} from '@angular/components-examples/cdk-experimental/listbox';
10+
import {CdkListboxExamplesModule} from '@angular/components-examples/cdk/listbox';
1111

1212
@Component({
1313
templateUrl: 'cdk-listbox-demo.html',

src/dev-app/dev-app/dev-app-layout.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@ export class DevAppLayout {
5353
{name: 'Button', route: '/button'},
5454
{name: 'Card', route: '/card'},
5555
{name: 'CDK Dialog', route: '/cdk-dialog'},
56+
{name: 'CDK Listbox', route: '/cdk-listbox'},
5657
{name: 'CDK Menu', route: '/cdk-menu'},
5758
{name: 'CDK Experimental Combobox', route: '/cdk-experimental-combobox'},
58-
{name: 'CDK Experimental Listbox', route: '/cdk-experimental-listbox'},
5959
{name: 'Checkbox', route: '/checkbox'},
6060
{name: 'Chips', route: '/chips'},
6161
{name: 'Clipboard', route: '/clipboard'},

src/dev-app/routes.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,8 @@ export const DEV_APP_ROUTES: Routes = [
5050
loadComponent: () => import('./cdk-dialog/dialog-demo').then(m => m.DialogDemo),
5151
},
5252
{
53-
path: 'cdk-experimental-listbox',
54-
loadComponent: () =>
55-
import('./cdk-experimental-listbox/cdk-listbox-demo').then(m => m.CdkListboxDemo),
53+
path: 'cdk-listbox',
54+
loadComponent: () => import('./cdk-listbox/cdk-listbox-demo').then(m => m.CdkListboxDemo),
5655
},
5756
{
5857
path: 'cdk-menu',

tools/public_api_guard/cdk/listbox.md

Lines changed: 139 additions & 0 deletions

0 commit comments

Comments
 (0)