v0.8.3

Author: btford

dist/hint.js

@@ -9,6 +9,7 @@ require('angular-hint');
 
 angular.hint.onAny(function (data, severity) {
   window.postMessage({
+    __fromBatarang: true,
     module: this.event.split(':')[0],
     event: this.event,
     data: data,
@@ -1363,12 +1364,17 @@ module.exports = function(str) {
     return true;
   }
 
-  if(str.toLowerCase() === str || str.charAt(0).toUpperCase() === str.charAt(0)) {
+  if(str.charAt(0).toUpperCase() === str.charAt(0)) {
     angular.hint.emit(MODULE_NAME, 'The best practice for' +
-      ' module names is to use lowerCamelCase. Check the name of "' + str + '".',
+      ' module names is to use dot.case or lowerCamelCase. Check the name of "' + str + '".',
       SEVERITY_SUGGESTION);
     return false;
   }
+  if(str.toLowerCase() === str && str.indexOf('.') === -1) {
+    angular.hint.emit(MODULE_NAME, 'Module names should be namespaced' +
+      ' with a dot (app.dashboard) or lowerCamelCase (appDashboard). Check the name of "' + str + '".', SEVERITY_SUGGESTION);
+    return false;
+  }
   return true;
 };
 
@@ -1627,18 +1633,43 @@ angular.module = function() {
 var ngEventAttributes = require('../lib/event-directives'),
     MODULE_NAME = 'Events';
 
+/*
+ * Remove string expressions except property accessors.
+ * ex. abc["def"] = "gef"; // `removeStringExp` will remove "gef" but not "def".
+ */
+function removeStringExp(str) {
+  return str.replace(/"(?:[^"\\]|\\.)*"|'(?:[^'\\]|\\.)*'/g,
+    function(match, pos, full) {
+      // this is our lookaround code so that our regex doesn't become so
+      // complicated.
+      if (pos !== 0 && (match.length + pos) !== full.length &&
+          full[pos - 1] === '[' && full[pos + match.length] === ']') {
+           return match;
+      }
+      return '';
+    });
+}
 
 var getFunctionNames = function(str) {
   if (typeof str !== 'string') {
     return [];
   }
-  var results = str.replace(/\s+/g, '').split(/[\+\-\/\|\<\>\^=&!%~;]/g).map(function(x) {
-    if (isNaN(+x)) {
-      if (x.match(/\w+\(.*\)$/)){
-        return x.substr(0, x.indexOf('('));
+  // There are still a bunch of corner cases here where we aren't going to be able to handle
+  // but we shouldn't break the user's app and we should handle most common cases.
+  // example of corner cases: we can't check for properties inside of function
+  // arguments like `move(a.b.c)` with the current implementation
+  // or property accessors with parentheses in them
+  // like `prop["hello (world)"] = "test";`.
+  // To fully fix these issues we would need a full blown expression parser.
+  var results = removeStringExp(str.replace(/\s+/g, ''))
+    .replace(/\(.*?\)/g, '')
+    .split(/[\+\-\/\|\<\>\^=&!%~;]/g).map(function(x) {
+      if (isNaN(+x)) {
+        if (x.match(/\w+\(.*\)$/)){
+          return x.substr(0, x.indexOf('('));
+        }
+        return x;
       }
-      return x;
-    }
   }).filter(function(x){
     return x;
   });

manifest.json

@@ -1,6 +1,6 @@
 {
   "name": "AngularJS Batarang",
-  "version": "0.8.2",
+  "version": "0.8.3",
   "description": "Extends the Developer Tools, adding tools for debugging and profiling AngularJS applications.",
   "devtools_page": "devtoolsBackground.html",
   "manifest_version": 2,

package.json

@@ -1,6 +1,6 @@
 {
   "name": "angularjs-batarang",
-  "version": "0.8.2",
+  "version": "0.8.3",
   "description": "chrome extension for inspecting angular apps",
   "main": "hint.js",
   "devDependencies": {