From 3024501fb214f00754a392c1562757fad7807240 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Karol=20Wypch=C5=82o?= Date: Thu, 6 Nov 2014 15:07:21 +0100 Subject: [PATCH] perf(orderBy): copy array with slice instead of for loop Use array slice method to copy entire array instead of a for loop http://jsperf.com/new-array-vs-splice-vs-slice/54 --- src/ng/filter/orderBy.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/ng/filter/orderBy.js b/src/ng/filter/orderBy.js index 078103dea79a..3dc947570e91 100644 --- a/src/ng/filter/orderBy.js +++ b/src/ng/filter/orderBy.js @@ -146,9 +146,7 @@ function orderByFilter($parse) { return compare(get(a),get(b)); }, descending); }); - var arrayCopy = []; - for (var i = 0; i < array.length; i++) { arrayCopy.push(array[i]); } - return arrayCopy.sort(reverseComparator(comparator, reverseOrder)); + return slice.call(array).sort(reverseComparator(comparator, reverseOrder)); function comparator(o1, o2) { for (var i = 0; i < sortPredicate.length; i++) {