From dfbc09898617788097f078d6f217de420498c574 Mon Sep 17 00:00:00 2001
From: Bob Larrick <larrick@gmail.com>
Date: Tue, 8 Jul 2014 16:56:53 -0400
Subject: [PATCH] fix(orderBy): changes orderBy to use case sensitive
 comparison to break ties on strings

Previously running orderBy on an array of strings such as ['A cow', 'a cow'] would
result in ['A cow', 'a cow'], regardless of the value of reverseOrder.  This is because orderBy cast
all strings to lowercase before comparing them.

This commit changes the behavior to result in ['a cow', 'A cow'] when reverseOrder is true,
and ['A cow', 'a cow'] when reverse order is false.
---
 src/ng/filter/orderBy.js      | 8 ++++++--
 test/ng/filter/orderBySpec.js | 6 ++++++
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/ng/filter/orderBy.js b/src/ng/filter/orderBy.js
index abd9f5857e8b..9bf7765e7c2b 100644
--- a/src/ng/filter/orderBy.js
+++ b/src/ng/filter/orderBy.js
@@ -154,8 +154,12 @@ function orderByFilter($parse){
       var t2 = typeof v2;
       if (t1 == t2) {
         if (t1 == "string") {
-           v1 = v1.toLowerCase();
-           v2 = v2.toLowerCase();
+           var v1Lower = v1.toLowerCase();
+           var v2Lower = v2.toLowerCase();
+           if (v1Lower !== v2Lower) {
+              v1 = v1Lower;
+              v2 = v2Lower;
+           }
         }
         if (v1 === v2) return 0;
         return v1 < v2 ? -1 : 1;
diff --git a/test/ng/filter/orderBySpec.js b/test/ng/filter/orderBySpec.js
index f7003d4b76e4..4224a99b965c 100644
--- a/test/ng/filter/orderBySpec.js
+++ b/test/ng/filter/orderBySpec.js
@@ -45,4 +45,10 @@ describe('Filter: orderBy', function() {
       return orderBy([{"Tip %": .15}, {"Tip %": .25}, {"Tip %": .40}], '"Tip %\'');
     }).toThrow();
   });
+
+  it('should sort strings in a case sensitive way', function() {
+    var array = [{name:"Bb"}, {name:"BB"}, {name:"bb"}, {name:'Aa'}, {name:'aa'}, {name:'AA'}];
+    expect(orderBy(array, 'name', true)).toEqualData([{name:"bb"}, {name:"Bb"}, {name:"BB"}, {name:'aa'}, {name:'Aa'}, {name:'AA'}]);
+    expect(orderBy(array, 'name', true)).toEqualData(orderBy(array, 'name', false).reverse());
+  });
 });