From a7775631a4a69e7ec5ae871e861cbdf183e98e72 Mon Sep 17 00:00:00 2001 From: J Bruni Date: Tue, 8 Oct 2013 00:09:06 -0300 Subject: [PATCH] Improved advanced form documentation example Pass the `$index` directly to the `removeContact` function, instead of searching for it in an expensive forEach loop. --- docs/content/cookbook/advancedform.ngdoc | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/docs/content/cookbook/advancedform.ngdoc b/docs/content/cookbook/advancedform.ngdoc index 1501f955609f..bcf8069a1072 100644 --- a/docs/content/cookbook/advancedform.ngdoc +++ b/docs/content/cookbook/advancedform.ngdoc @@ -38,13 +38,8 @@ detection, and preventing invalid form submission. $scope.form.contacts.push({type:'', value:''}); }; - $scope.removeContact = function(contact) { - var contacts = $scope.form.contacts; - for (var i = 0, ii = contacts.length; i < ii; i++) { - if (contact === contacts[i]) { - contacts.splice(i, 1); - } - } + $scope.removeContact = function(index) { + $scope.form.contacts.splice(index, 1); }; $scope.isCancelDisabled = function() { @@ -83,7 +78,7 @@ detection, and preventing invalid form submission. - [ X ] + [ X ]