From 354542df165b5f013a69695372861625d8e91f4e Mon Sep 17 00:00:00 2001 From: "SebC." Date: Mon, 23 Sep 2013 12:27:42 +0200 Subject: [PATCH 1/4] MSIE documentMode detection I guess we could delete the user-agent detection, but as I'm not sure, I left it. --- docs/component-spec/mocks.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/component-spec/mocks.js b/docs/component-spec/mocks.js index f916c0edee7a..b07e012582aa 100644 --- a/docs/component-spec/mocks.js +++ b/docs/component-spec/mocks.js @@ -1,5 +1,6 @@ // Copy/pasted from src/Angular.js, so that we can disable specific tests on IE. -var msie = parseInt((/msie (\d+)/.exec(navigator.userAgent.toLowerCase()) || [])[1], 10); +//var msie = parseInt((/msie (\d+)/.exec(navigator.userAgent.toLowerCase()) || [])[1], 10); +var msie = document.documentMode || parseInt((/msie (\d+)/.exec(navigator.userAgent.toLowerCase()) || [])[1], 10); var createMockWindow = function() { var mockWindow = {}; From ed80bad485499c4da0e7613ec14b1a6adcf7d052 Mon Sep 17 00:00:00 2001 From: "SebC." Date: Wed, 25 Sep 2013 15:23:38 +0200 Subject: [PATCH 2/4] MSIE documentMode detection replaces userAgent sniffing --- docs/component-spec/mocks.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/component-spec/mocks.js b/docs/component-spec/mocks.js index b07e012582aa..1b274454abea 100644 --- a/docs/component-spec/mocks.js +++ b/docs/component-spec/mocks.js @@ -1,6 +1,6 @@ // Copy/pasted from src/Angular.js, so that we can disable specific tests on IE. //var msie = parseInt((/msie (\d+)/.exec(navigator.userAgent.toLowerCase()) || [])[1], 10); -var msie = document.documentMode || parseInt((/msie (\d+)/.exec(navigator.userAgent.toLowerCase()) || [])[1], 10); +var msie = document.documentMode; var createMockWindow = function() { var mockWindow = {}; From a47721f3b17fa62e652e9ebcbd6e3a535067464d Mon Sep 17 00:00:00 2001 From: "SebC." Date: Wed, 25 Sep 2013 15:24:41 +0200 Subject: [PATCH 3/4] Update ngSwipeSpec.js --- test/ngTouch/directive/ngSwipeSpec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/ngTouch/directive/ngSwipeSpec.js b/test/ngTouch/directive/ngSwipeSpec.js index a7869a36639f..2628ea39b00d 100644 --- a/test/ngTouch/directive/ngSwipeSpec.js +++ b/test/ngTouch/directive/ngSwipeSpec.js @@ -17,7 +17,7 @@ var swipeTests = function(description, restrictBrowsers, startEvent, moveEvent, // Skip tests on IE < 9. These versions of IE don't support createEvent(), and so // we cannot control the (x,y) position of events. // It works fine in IE 8 under manual testing. - var msie = +((/msie (\d+)/.exec(navigator.userAgent.toLowerCase()) || [])[1]); + var msie = document.documentMode; if (msie < 9) { return; } From 73d160729d755f45db4286dffda3d6f9b5addcaf Mon Sep 17 00:00:00 2001 From: "SebC." Date: Wed, 25 Sep 2013 15:25:29 +0200 Subject: [PATCH 4/4] Update browserTrigger.js --- src/ngScenario/browserTrigger.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ngScenario/browserTrigger.js b/src/ngScenario/browserTrigger.js index 3da6d5eae9b7..44b0783fde91 100644 --- a/src/ngScenario/browserTrigger.js +++ b/src/ngScenario/browserTrigger.js @@ -1,7 +1,7 @@ 'use strict'; (function() { - var msie = parseInt((/msie (\d+)/.exec(navigator.userAgent.toLowerCase()) || [])[1], 10); + var msie = document.documentMode; function indexOf(array, obj) { if (array.indexOf) return array.indexOf(obj);